[lib] Change `decodeMinimallyEncodedRawThreadInfo` argument type to `RawThreadInfoWithMemberPermissions`
AbandonedPublic
Actions

Authored by atul on Jun 25 2024, 9:54 AM.

Tags

None

Referenced Files

	F3539256: D12573.id41697.diff
	Thu, Dec 26, 12:17 AM

	F3534613: D12573.diff
	Wed, Dec 25, 12:40 PM

	Unknown Object (File)
	Thu, Dec 19, 7:02 AM

	Unknown Object (File)
	Thu, Dec 19, 7:02 AM

	Unknown Object (File)
	Thu, Dec 19, 7:02 AM

	Unknown Object (File)
	Thu, Dec 12, 5:37 PM

	Unknown Object (File)
	Fri, Dec 6, 1:00 AM

	Unknown Object (File)
	Fri, Dec 6, 12:58 AM

View All 51 Files

Subscribers

None

Details

Reviewers

ashoat
ginsu
tomek

Summary

Brings us from 34 to 29 flow issues.

Depends on D12557

Test Plan

flow + looked at callsites to ensure things are as expected.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jun 25 2024, 9:54 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 25 2024, 10:07 AM

Harbormaster failed remote builds in B29923: Diff 41697!

atul added a child revision: D12574: [native] Add `$FlowIgnore` annotation to migration 61.Jun 25 2024, 10:08 AM

atul requested review of this revision.Jun 26 2024, 9:36 AM

atul added inline comments.

lib/shared/redux/update-roles-and-permissions.js
13	This import will be removed.

Abandoning in favor of stack starting with D12594 because lots of things have changed and there's not really 1:1 correspondence with old stack and new stack so I don't think it makes sense to update in place, change a bunch of child/parent diff relationships, etc.