Page MenuHomePhabricator

[native] Add `$FlowIgnore` annotation to migration 61
AbandonedPublic

Authored by atul on Jun 25 2024, 10:08 AM.
Tags
None
Referenced Files
F3534623: D12574.diff
Wed, Dec 25, 12:45 PM
Unknown Object (File)
Thu, Dec 19, 7:16 AM
Unknown Object (File)
Thu, Dec 19, 7:16 AM
Unknown Object (File)
Thu, Dec 19, 7:16 AM
Unknown Object (File)
Wed, Dec 18, 3:14 AM
Unknown Object (File)
Fri, Dec 6, 1:06 AM
Unknown Object (File)
Fri, Dec 6, 1:05 AM
Unknown Object (File)
Fri, Dec 6, 12:42 AM
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
Summary

Add flow error suppression to migration 61 where we know LegacyRawThreadInfo and RawThreadInfo will have member.permissions at time of migration in call to minimallyEncodeRawThreadInfo.

Brings flow issues from 29 to 28.


Depends on D12573

Test Plan

flow + careful reading

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul published this revision for review.Jun 25 2024, 10:20 AM
IMPORTANT: As mentioned in https://phab.comm.dev/D12557#356476, we will want to read through this carefully to ensure that migration continues to work as expected even if there are no flow issues in stack beginning D12594.

Abandoning in favor of stack starting with D12594 because lots of things have changed and there's not really 1:1 correspondence with old stack and new stack so I don't think it makes sense to update in place, change a bunch of child/parent diff relationships, etc.