Page MenuHomePhabricator
Differential D12591

[landing] add link to download page in the header
ClosedPublic
Actions

Authored by ginsu on Jun 27 2024, 10:20 AM.
Tags
None
Referenced Files
F3380585: D12591.id41760.diff
Thu, Nov 28, 12:46 AM
F3380583: D12591.id41859.diff
Thu, Nov 28, 12:44 AM
F3380582: D12591.id41856.diff
Thu, Nov 28, 12:44 AM
F3380310: D12591.diff
Wed, Nov 27, 10:45 PM
Unknown Object (File)
Tue, Nov 12, 12:07 PM
Unknown Object (File)
Tue, Nov 12, 9:49 AM
Unknown Object (File)
Tue, Nov 12, 7:44 AM
Unknown Object (File)
Tue, Nov 12, 6:30 AM
View All 60 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
ashoat
Commits
rCOMM1ca7214148fa: [landing] add link to download page in the header
Summary

We need to introduce a new button in the header that links to the download page I just introduced

Depends on D12583

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jun 27 2024, 10:20 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 27 2024, 10:20 AM
ginsu edited the summary of this revision. (Show Details)Jun 27 2024, 10:23 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: inka, ashoat.
ginsu added a parent revision: D12583: [landing] introduce download page.
ginsu attached a referenced file: F2128288: Screen Recording 2024-06-27 at 1.21.08 PM.mov. (Show Details)
ginsu added inline comments.Jun 27 2024, 10:25 AM
landing/header.css
75

Decided to make the hover effect for the web app icon and the download icon be the same purple circle so rename this to be a bit more generic

ginsu added a child revision: D12592: [landing] add download icon to mobile nav.Jun 27 2024, 10:28 AM
Harbormaster completed remote builds in B29962: Diff 41760.Jun 27 2024, 10:36 AM
ginsu requested review of this revision.Jun 27 2024, 10:36 AM
ashoat accepted this revision.EditedJul 1 2024, 12:12 PM

Can you add a video of what the dropdown menu looks like when the width is decreased? I want to make sure the download link appears there too

EDIT nevermind that's in D12592

This revision is now accepted and ready to land.Jul 1 2024, 12:12 PM
ginsu updated this revision to Diff 41856.Jul 1 2024, 12:28 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jul 1 2024, 12:31 PM
Closed by commit rCOMM1ca7214148fa: [landing] add link to download page in the header (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM1ca7214148fa: [landing] add link to download page in the header.
Harbormaster completed remote builds in B30032: Diff 41856.Jul 1 2024, 12:47 PM

Revision Contents
Changeset List

PathSize
landing/
10 lines
19 lines
15 lines

Diff 41760

View Options

landing/header.css

Loading...
View Options

landing/header.react.js

Loading...
View Options

landing/landing.react.js

Loading...