[identity] ensure identity reqwest crate has rustls-tls
ClosedPublic
Actions

Authored by will on Jun 28 2024, 1:00 PM.

Details

Reviewers

bartek
varun

Commits

rCOMM41b1598dab24: [identity] ensure identity reqwest crate has rustls-tls

Summary

We disabled default features for reqwest when we upgraded to cargo workspaces. This caused reqwest to compile without defalut TLS capability, leading to
https://linear.app/comm/issue/ENG-8611/identity-user-search-not-working-on-staging

This diff adds rustls-tls as a feature to the reqwest crate

Test Plan

Ran reqwest search query request to opensearch domain with no default features, causing

Error: reqwest::Error { kind: Request, url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("opensearch-domain")), port: None, path: "/users/_search/", query: None, fragment: None }, source: hyper_util::client::legacy::Error(Connect, "invalid URL, scheme is not http") }

On adding back rustls-tls, this resolved the issue and returned search results. Tested on upgraded identity image and search results on the iOS simulator app was restored

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Jun 28 2024, 1:00 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 28 2024, 1:00 PM

will published this revision for review.Jun 28 2024, 1:01 PM

varun accepted this revision.Jun 28 2024, 1:01 PM

This revision is now accepted and ready to land.Jun 28 2024, 1:01 PM

Harbormaster failed remote builds in B30008: Diff 41822!Jun 28 2024, 1:11 PM

recompile backup_client from workspace cargo.toml change

will added a child revision: D12622: [terraform] upgrade identity staging image to 0.27-staging.Jun 28 2024, 1:42 PM

Harbormaster failed remote builds in B30009: Diff 41823!Jun 28 2024, 2:12 PM

revamp. No longer reenabling default features. Instead just adding to rustls-tls to identity Cargo.toml

will retitled this revision from [services] add back default features to reqwest in cargo workspaces to [identity] ensure identity reqwest crate has rustls-tls.Jun 28 2024, 2:58 PM

will edited the summary of this revision. (Show Details)

will edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B30011: Diff 41825.Jun 28 2024, 3:13 PM

will edited the test plan for this revision. (Show Details)Jun 28 2024, 3:19 PM

Closed by commit rCOMM41b1598dab24: [identity] ensure identity reqwest crate has rustls-tls (authored by will). · Explain WhyJun 28 2024, 3:27 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM41b1598dab24: [identity] ensure identity reqwest crate has rustls-tls.