This requires changes in a lot of places because we were assuming that a thread ID is present.
Details
Details
Mostly Flow. Tested some simple scenarios, e.g. sending a message.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- master12
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/actions/activity-actions.js | ||
|---|---|---|
| 32–34 | It really feels like we should extract this to a function | |
| lib/keyserver-conn/keyserver-call-utils.js | ||
| 21 | This will throw in keyserverAuth if threadWatcher.getWatchedIDs() includes thick threads. Are we sure this can't happen? | |
| native/chat/settings/thread-settings-push-notifs.react.js | ||
| 179–184 | I feel like this could be done inside of deviceTokenSelector, but not sure | |
| web/calendar/entry.react.js | ||
| 479–481 | Shouldn't this be checking some connection to tunnelbroker? Probably not in this diff, but it feels like we shouldn't just leave this like that. There probably is a reason for checking if we can send the save entry request | |
| lib/keyserver-conn/keyserver-call-utils.js | ||
|---|---|---|
| 21 | Great catch | |
| web/calendar/entry.react.js | ||
| 479–481 | Looks like the only place this is used is to trigger auto-retries of failed entry updates once we detect the user has come online What @tomek is doing here is basically disabling that automatic retry. Checking Tunnelbroker connection would probably be appropriate, but it might not be necessary if we have a separate automatic retry mechanism, which I think @tomek is planning for this month (but tracked separately) Unrelated: I might suggest collapsing this all into a single const online = useSelector | |
| native/chat/settings/thread-settings-push-notifs.react.js | ||
|---|---|---|
| 179–184 | That would make sense, but I'm not sure if in other places where this selector is used, we should present a tunnelbroker token. | |
| lib/keyserver-conn/keyserver-call-utils.js | ||
|---|---|---|
| 76 ↗ | (On Diff #42142) | I don't think !keyserverID can happen here? extractKeyserverIDFromID is the one that throws, right? |
| native/components/auto-join-community-handler.react.js | ||
| 129 ↗ | (On Diff #42142) | We could use extractKeyserverIDFromID here, because we don't expect thick threads to be tagged with farcaster, but up to you |
| web/calendar/entry.react.js | ||
|---|---|---|
| 479–481 | I probably should do something about documenting it. Going to figure something out before landing the diff. | |