Page MenuHomePhabricator
Differential D12675

[native] update copy for thread notification settings
ClosedPublic
Actions

Authored by ginsu on Jul 5 2024, 11:05 AM.
Tags
None
Referenced Files
F3571378: D12675.id42093.diff
Sat, Dec 28, 9:13 AM
F3571377: D12675.id42092.diff
Sat, Dec 28, 9:13 AM
F3571376: D12675.id42081.diff
Sat, Dec 28, 9:13 AM
F3571375: D12675.id42084.diff
Sat, Dec 28, 9:13 AM
F3571374: D12675.id.diff
Sat, Dec 28, 9:13 AM
F3571373: D12675.diff
Sat, Dec 28, 9:13 AM
Unknown Object (File)
Nov 24 2024, 7:54 AM
Unknown Object (File)
Nov 24 2024, 6:04 AM
View All 77 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
inka
Commits
rCOMM335064c59cf1: [native] update copy for thread notification settings
Summary

Breaking this task into multiple diffs becasue there are actually a lot of places that need to be changed + updated

Linear task: https://linear.app/comm/issue/ENG-8455/rename-focused-to-home-and-background-to-muted

Test Plan

flow + confirmed that both the thread notif settings uis had the new copy

Screenshot 2024-07-05 at 2.05.42 PM.png (2×3 px, 857 KB)

Screenshot 2024-07-05 at 2.05.28 PM.png (1×1 px, 752 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jul 5 2024, 11:05 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 5 2024, 11:05 AM
ginsu edited the test plan for this revision. (Show Details)Jul 5 2024, 11:06 AM
ginsu added reviewers: ashoat, inka.
ginsu attached a referenced file: F2195746: Screenshot 2024-07-05 at 2.05.28 PM.png. (Show Details)
ginsu attached a referenced file: F2195747: Screenshot 2024-07-05 at 2.05.42 PM.png. (Show Details)
ginsu edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B30170: Diff 42081.Jul 5 2024, 11:21 AM
ginsu requested review of this revision.Jul 5 2024, 11:21 AM
ginsu planned changes to this revision.Jul 5 2024, 12:45 PM

Found a bug with saving the thread notif settings

ginsu updated this revision to Diff 42084.Jul 5 2024, 12:59 PM

update

Harbormaster failed remote builds in B30173: Diff 42084!Jul 5 2024, 1:24 PM
ashoat accepted this revision.Jul 5 2024, 1:31 PM
ashoat added inline comments.
lib/shared/thread-settings-notifications-utils.js
77–85

These strings are only used locally, right? They're not used for communication between clients / keyserver / services / etc.?

This revision is now accepted and ready to land.Jul 5 2024, 1:31 PM
Harbormaster completed remote builds in B30173: Diff 42084.Jul 5 2024, 1:32 PM
ginsu added inline comments.Jul 7 2024, 10:27 PM
lib/shared/thread-settings-notifications-utils.js
77–85

Yes these are only used for the notificationSettings local state in this hook

ginsu updated this revision to Diff 42092.Jul 7 2024, 10:28 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jul 7 2024, 10:31 PM
Closed by commit rCOMM335064c59cf1: [native] update copy for thread notification settings (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM335064c59cf1: [native] update copy for thread notification settings.
Harbormaster completed remote builds in B30181: Diff 42092.Jul 7 2024, 10:44 PM

Revision Contents
Changeset List

PathSize
lib/
shared/
74 lines
native/
chat/
settings/
110 lines
6 lines
web/
modals/
threads/
notifications/
82 lines

Diff 42084

View Options

lib/shared/thread-settings-notifications-utils.js

Loading...
View Options

native/chat/settings/thread-settings-notifications.react.js

Loading...
View Options

native/chat/settings/thread-settings-push-notifs.react.js

Loading...
View Options

web/modals/threads/notifications/notifications-modal.react.js

Loading...