Page MenuHomePhabricator

[native] update copy for thread notification settings
ClosedPublic

Authored by ginsu on Jul 5 2024, 11:05 AM.
Tags
None
Referenced Files
F3181922: D12675.id42093.diff
Fri, Nov 8, 7:14 AM
Unknown Object (File)
Fri, Oct 11, 5:26 AM
Unknown Object (File)
Fri, Oct 11, 5:26 AM
Unknown Object (File)
Fri, Oct 11, 5:26 AM
Unknown Object (File)
Fri, Oct 11, 5:26 AM
Unknown Object (File)
Oct 6 2024, 1:28 PM
Unknown Object (File)
Oct 6 2024, 12:27 PM
Unknown Object (File)
Sep 25 2024, 8:51 PM
Subscribers

Details

Summary

Breaking this task into multiple diffs becasue there are actually a lot of places that need to be changed + updated

Linear task: https://linear.app/comm/issue/ENG-8455/rename-focused-to-home-and-background-to-muted

Test Plan

flow + confirmed that both the thread notif settings uis had the new copy

Screenshot 2024-07-05 at 2.05.42 PM.png (2×3 px, 857 KB)

Screenshot 2024-07-05 at 2.05.28 PM.png (1×1 px, 752 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu added reviewers: ashoat, inka.
ginsu edited the summary of this revision. (Show Details)
ginsu requested review of this revision.Jul 5 2024, 11:21 AM

Found a bug with saving the thread notif settings

ashoat added inline comments.
lib/shared/thread-settings-notifications-utils.js
77–85 ↗(On Diff #42084)

These strings are only used locally, right? They're not used for communication between clients / keyserver / services / etc.?

This revision is now accepted and ready to land.Jul 5 2024, 1:31 PM
lib/shared/thread-settings-notifications-utils.js
77–85 ↗(On Diff #42084)

Yes these are only used for the notificationSettings local state in this hook

This revision was landed with ongoing or failed builds.Jul 7 2024, 10:31 PM
This revision was automatically updated to reflect the committed changes.