Page MenuHomePhabricator
Differential D12822

[terraform] bump staging identity to 0.32-staging
ClosedPublic
Actions

Authored by varun on Jul 20 2024, 12:00 AM.
Tags
None
Referenced Files
F5364087: D12822.id42614.diff
Wed, Apr 9, 1:42 PM
F5357260: D12822.diff
Wed, Apr 9, 11:40 AM
Unknown Object (File)
Wed, Apr 9, 3:06 AM
Unknown Object (File)
Tue, Apr 8, 8:00 PM
Unknown Object (File)
Tue, Apr 8, 9:59 AM
Unknown Object (File)
Fri, Mar 28, 6:07 AM
Unknown Object (File)
Mar 7 2025, 6:06 AM
Unknown Object (File)
Feb 28 2025, 1:17 AM
View All 63 Files
Subscribers
tomek

Details

Reviewers
ashoat
will
bartek
Commits
rCOMM7c295141bbfc: [terraform] bump staging identity to 0.32-staging
Summary

this contains the fix for leaked sensitive data in logs

Depends on D12820

Test Plan

terraform plan

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
services/
terraform/
remote/
2 lines

Diff 42585

View Options

services/terraform/remote/service_identity.tf

  • This file was added.
// @flow
import type { CommunityInfo } from 'lib/types/community-types.js';
import { dbQuery, SQL } from '../database/database.js';
import { Viewer } from '../session/viewer.js';
type ServerCommunityInfoWithHolder = {
...CommunityInfo,
+id: string,
+blobHolder: ?string,
};
tomekUnsubmitted
Not Done
Inline Actions
import { Viewer } from '../session/viewer.js';
- type ServerCommunityInfoWithHolder = {
+ type ServerCommunityInfoWithHolder = $ReadOnly<{
...CommunityInfo,
+id: string,
+blobHolder: ?string,
- };
+ }>;
async function fetchCommunityInfos(

We should make this readonly because spreading a type makes it writable.

tomek: We should make this readonly because spreading a type makes it writable.
async function fetchCommunityInfos(
viewer: Viewer,
): Promise<$ReadOnlyArray<ServerCommunityInfoWithHolder>> {
if (!viewer) {
return [];
}
const query = SQL`
SELECT c.id, c.farcaster_channel_id as farcasterChannelID,
c.blob_holder as blobHolder
FROM communities c
INNER JOIN memberships m
ON c.id = m.thread AND m.user = ${viewer.userID}
WHERE m.role > 0
`;
const [result] = await dbQuery(query);
const communityInfos = result.map(row => {
return {
id: row.id.toString(),
farcasterChannelID: row.farcasterChannelID,
blobHolder: row.blobHolder,
};
});
tomekUnsubmitted
Not Done
Inline Actions
const [result] = await dbQuery(query);
- const communityInfos = result.map(row => {
- return {
+ const communityInfos = result.map(row => ({
id: row.id.toString(),
farcasterChannelID: row.farcasterChannelID,
blobHolder: row.blobHolder,
- };
});
return communityInfos;
tomek:
return communityInfos;
}
export { fetchCommunityInfos };