[terraform] Avoid including Terraform *.tfstate.backup in keyserver docker images
ClosedPublic
Actions

Authored by will on Jul 22 2024, 5:55 PM.

Details

Reviewers

varun
bartek
ashoat

Commits

rCOMM139ef005b33b: [terraform] Avoid including Terraform *.tfstate.backup in keyserver docker…

Summary

Files like terraform.tfstate.backup expose secrets in the keyserver image and should be

Test Plan

Tested by building the docker image, opening the build with docker run -it docker_image bash and
searching for my password cd .. && (grep -R password_string . | grep -v node_modules) as we did in https://phab.comm.dev/D12823

Diff Detail

Repository

rCOMM Comm

Branch

add_to_dockerignore

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Jul 22 2024, 5:55 PM

Herald added a subscriber: tomek. · View Herald TranscriptJul 22 2024, 5:55 PM

will edited the test plan for this revision. (Show Details)Jul 22 2024, 5:56 PM

ashoat published this revision for review.Jul 22 2024, 5:56 PM

ashoat accepted this revision.

This revision is now accepted and ready to land.Jul 22 2024, 5:56 PM

Harbormaster completed remote builds in B30581: Diff 42649.Jul 22 2024, 6:12 PM

Closed by commit rCOMM139ef005b33b: [terraform] Avoid including Terraform *.tfstate.backup in keyserver docker… (authored by will). · Explain WhyJul 22 2024, 6:13 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM139ef005b33b: [terraform] Avoid including Terraform *.tfstate.backup in keyserver docker….

Revision Contents
Changeset List

Path

Size

.dockerignore

1 line

Diff 42649

View Options

[terraform] Avoid including Terraform *.tfstate.backup in keyserver docker imagesClosedPublicActions