Page MenuHomePhabricator
Differential D12856

[Tunnelbroker][lib] cleanup Device <-> Tunnelbroker message types
ClosedPublic
Actions

Authored by kamil on Jul 23 2024, 5:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 11:51 AM
Unknown Object (File)
Fri, Oct 18, 10:07 AM
Unknown Object (File)
Fri, Oct 18, 3:21 AM
Unknown Object (File)
Mon, Oct 14, 1:02 PM
Unknown Object (File)
Mon, Oct 14, 1:02 PM
Unknown Object (File)
Mon, Oct 14, 1:02 PM
Unknown Object (File)
Mon, Oct 14, 1:02 PM
Unknown Object (File)
Mon, Oct 14, 1:01 PM
View All 49 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMM46915f332915: [Tunnelbroker][lib] cleanup Device <-> Tunnelbroker message types
Summary

ENG-8621.

This improves readability, we can distingiush direction of message sender and recipient.

Test Plan

This only changes types, should not affect logic or content of messages sent between device <-> Tunnelbroker so only yarn flow:all and cargo check.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jul 23 2024, 5:53 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 23 2024, 5:53 AM
kamil edited the summary of this revision. (Show Details)Jul 23 2024, 5:57 AM
kamil removed a parent revision: D12841: [Tunnelbroker] implement Web Push config.
kamil published this revision for review.Jul 23 2024, 6:20 AM
kamil added a child revision: D12857: [lib] remove unused Tunnelbroker message validators.Jul 23 2024, 6:20 AM
tomek accepted this revision.Jul 24 2024, 6:03 AM
tomek added inline comments.
lib/tunnelbroker/tunnelbroker-context.js
300 ↗(On Diff #42686)

Are you sure this is the right type? Shouldn't be deviceToTunnelbroker?

This revision is now accepted and ready to land.Jul 24 2024, 6:03 AM
kamil updated this revision to Diff 42762.Jul 25 2024, 1:54 AM
kamil edited the summary of this revision. (Show Details)

use deviceToTunnelbroker

Harbormaster completed remote builds in B30662: Diff 42762.Jul 25 2024, 2:10 AM
Closed by commit rCOMM46915f332915: [Tunnelbroker][lib] cleanup Device <-> Tunnelbroker message types (authored by kamil). · Explain WhyJul 25 2024, 2:54 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM46915f332915: [Tunnelbroker][lib] cleanup Device <-> Tunnelbroker message types.

Revision Contents
Changeset List

PathSize
keyserver/
src/
socket/
33 lines
lib/
components/
8 lines
tunnelbroker/
11 lines
27 lines
types/
tunnelbroker/
68 lines
native/
profile/
9 lines
10 lines
services/
commtest/
src/
tunnelbroker/
10 lines
tunnelbroker/
src/
websockets/
33 lines
shared/
tunnelbroker_messages/
src/
messages/
26 lines
web/
settings/
14 lines

Diff 42764

View Options

keyserver/src/socket/tunnelbroker.js

Loading...
View Options

lib/components/qr-auth-provider.react.js

Loading...
View Options

lib/tunnelbroker/peer-to-peer-message-handler.js

Loading...
View Options

lib/tunnelbroker/tunnelbroker-context.js

Loading...
View Options

lib/types/tunnelbroker/messages.js

Loading...
View Options

native/profile/secondary-device-qr-code-scanner.react.js

Loading...
View Options

native/profile/tunnelbroker-menu.react.js

Loading...
View Options

services/commtest/src/tunnelbroker/socket.rs

Loading...
View Options

services/tunnelbroker/src/websockets/session.rs

Loading...
View Options

shared/tunnelbroker_messages/src/messages/mod.rs

Loading...
View Options

web/settings/tunnelbroker-message-list.react.js

Loading...