Page MenuHomePhabricator

[identity] Forbid duplicated devices in device lists
ClosedPublic

Authored by bartek on Jul 25 2024, 10:19 PM.
Tags
None
Referenced Files
F3374335: D12886.diff
Tue, Nov 26, 3:06 PM
Unknown Object (File)
Thu, Nov 14, 6:54 PM
Unknown Object (File)
Fri, Nov 8, 10:36 PM
Unknown Object (File)
Fri, Nov 8, 1:43 PM
Unknown Object (File)
Fri, Nov 8, 12:22 PM
Unknown Object (File)
Fri, Nov 8, 12:22 PM
Unknown Object (File)
Thu, Nov 7, 8:50 AM
Unknown Object (File)
Oct 22 2024, 9:20 AM
Subscribers

Details

Summary

Addresses ENG-8898.
Added a condition to check if the device list udpate contains duplicates.

Test Plan

Added unit test

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Jul 25 2024, 10:27 PM
bartek added inline comments.
services/identity/src/device_list.rs
331–332

copied() is only needed to convert &&str into &str. It's cheap

This revision is now accepted and ready to land.Jul 26 2024, 8:14 AM
This revision was landed with ongoing or failed builds.Jul 29 2024, 12:16 AM
This revision was automatically updated to reflect the committed changes.