Page MenuHomePhabricator
Differential D12859

[Tunnelbroker][lib] rename `MessageToDeviceRequestStatus` -> `DeviceToTunnelbrokerRequestStatus`
ClosedPublic
Actions

Authored by kamil on Jul 23 2024, 7:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 1:49 PM
Unknown Object (File)
Tue, Nov 12, 12:27 PM
Unknown Object (File)
Mon, Nov 4, 12:53 PM
Unknown Object (File)
Fri, Nov 1, 8:15 PM
Unknown Object (File)
Oct 18 2024, 1:51 AM
Unknown Object (File)
Oct 14 2024, 1:02 PM
Unknown Object (File)
Oct 14 2024, 1:02 PM
Unknown Object (File)
Oct 14 2024, 1:02 PM
View All 53 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
Commits
rCOMMde4f19f5b3f5: [Tunnelbroker][lib] rename `MessageToDeviceRequestStatus` ->…
Summary

ENG-8621.
ENG-8609

After we launched CSAT we can rename only static type to not break older clients.

Depends on D12858

Test Plan

Flow and Tunnelbroker integration tests

Diff Detail

Repository
rCOMM Comm
Branch
land-2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jul 23 2024, 7:06 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 23 2024, 7:06 AM
Harbormaster completed remote builds in B30610: Diff 42697.Jul 23 2024, 7:25 AM
kamil published this revision for review.Jul 25 2024, 1:45 AM
tomek accepted this revision.Jul 25 2024, 6:28 AM
tomek added inline comments.
shared/tunnelbroker_messages/src/messages/message_to_device_request_status.rs
37–38 ↗(On Diff #42697)

Might be worth testing it.

This revision is now accepted and ready to land.Jul 25 2024, 6:28 AM
kamil updated this revision to Diff 42797.Jul 26 2024, 2:22 AM

use rename and test with device

Harbormaster failed remote builds in B30685: Diff 42797!Jul 26 2024, 2:26 AM
Harbormaster completed remote builds in B30685: Diff 42797.Jul 26 2024, 2:38 AM
Closed by commit rCOMMde4f19f5b3f5: [Tunnelbroker][lib] rename `MessageToDeviceRequestStatus` ->… (authored by kamil). · Explain WhyJul 26 2024, 2:39 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMde4f19f5b3f5: [Tunnelbroker][lib] rename `MessageToDeviceRequestStatus` ->….

Revision Contents
Changeset List

PathSize
keyserver/
src/
socket/
4 lines
lib/
tunnelbroker/
4 lines
types/
tunnelbroker/
device-to-tunnelbroker-request-status-types.js
message-to-device-request-status-types.js
6 lines
10 lines
services/
commtest/
src/
tunnelbroker/
6 lines
tests/
8 lines
tunnelbroker/
src/
websockets/
8 lines
shared/
tunnelbroker_messages/
src/
messages/
26 lines
2 lines

Diff 42797

View Options

keyserver/src/socket/tunnelbroker.js

Loading...
View Options

lib/tunnelbroker/tunnelbroker-context.js

Loading...
View Options

lib/types/tunnelbroker/device-to-tunnelbroker-request-status-types.js

Loading...
View Options

lib/types/tunnelbroker/message-to-device-request-status-types.js

Loading...
View Options

lib/types/tunnelbroker/messages.js

Loading...
View Options

services/commtest/src/tunnelbroker/socket.rs

Loading...
View Options

services/commtest/tests/tunnelbroker_sender_confirmation_tests.rs

Loading...
View Options

services/tunnelbroker/src/websockets/mod.rs

Loading...
View Options

shared/tunnelbroker_messages/src/messages/message_to_device_request_status.rs

Loading...
View Options

shared/tunnelbroker_messages/src/messages/mod.rs

Loading...