[identity] Ask Tunnelbroker to delete data on account deletion
ClosedPublic
Actions

Authored by bartek on Jul 29 2024, 7:02 AM.

Details

Reviewers

kamil
varun

Commits

rCOMM119e9b84e7b7: [identity] Ask Tunnelbroker to delete data on account deletion

Summary

From DeleteUser identity RPCs, call Tunnelbroker to delete data for all user's device IDs.

Test Plan

Test plan from D12917. Replaced manual Tunnelbroker RPC call with Identity DeleteUser RPC.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jul 29 2024, 7:02 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 29 2024, 7:02 AM

bartek published this revision for review.Jul 29 2024, 7:17 AM

bartek added inline comments.

services/identity/src/database.rs
541–545	We could theoretically retrieve device IDs from deleted data in delete requests, but that would complicate the code too much, so I decided to simply call this before deletion attempt.

Harbormaster completed remote builds in B30758: Diff 42900.Jul 29 2024, 7:18 AM

kamil accepted this revision.Jul 30 2024, 4:24 AM

This revision is now accepted and ready to land.Jul 30 2024, 4:24 AM

bartek edited the summary of this revision. (Show Details)Aug 5 2024, 5:00 AM

bartek removed a parent revision: D12917: [tunnelbroker] Implement messages TTL after device deletion.

Closed by commit rCOMM119e9b84e7b7: [identity] Ask Tunnelbroker to delete data on account deletion (authored by bartek). · Explain WhyAug 5 2024, 5:54 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM119e9b84e7b7: [identity] Ask Tunnelbroker to delete data on account deletion.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database.rs

14 lines

grpc_services/

authenticated.rs

6 lines

Diff 42900

View Options

services/identity/src/database.rs