[native] Add jcenter() as a fallback in our react-native-ffmpeg patch
ClosedPublic
Actions

Authored by ashoat on Aug 5 2024, 2:13 PM.

Details

Reviewers

will

Commits

rCOMMc4b734c1814f: [native] Add jcenter() as a fallback in our react-native-ffmpeg patch

Summary

This resolves ENG-8959, an issue where our Android build is failing down to intermittent downtime from gradlePluginPortal() preventing us from downloading artifacts necessary for react-native-ffmpeg.

gradlePluginPortal() is a mirror of jcenter(). We switched from jcenter() to it due to intermittent JCenter downtime in D5510. We later reintroduced jcenter() as a fallback for our main native/android/build.gradle Gradle file in D5551, but we failed to reintroduce the jcenter() fallback for our react-native-ffmpeg patch.

This diff introduces the jcenter() fallback for our react-native-ffmpeg patch.

Test Plan

On my local machine, the Android build got past the part that was failing
I will make sure Buildkite CI passes before landing

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/android

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Aug 5 2024, 2:13 PM

Herald added a subscriber: tomek. · View Herald TranscriptAug 5 2024, 2:13 PM

Requesting review, but will wait on Android CI before landing

patches/react-native-ffmpeg+0.4.4.patch
13	Not sure why this change occurred. I didn't manually touch the file (just ran `patch-package`). Guessing somebody previously accidentally added the newline, and it didn't break `patch-package` so it wasn't noticed

will accepted this revision.Aug 5 2024, 2:14 PM

This revision is now accepted and ready to land.Aug 5 2024, 2:14 PM

Harbormaster failed remote builds in B30944: Diff 43159!Aug 5 2024, 2:36 PM

ashoat added a child revision: D12993: [native] Update to react-native-ffmpeg@0.5.2.Aug 5 2024, 4:05 PM

The issue appeared to have gone away (see here). I'm going to go ahead and land this anyways (after checking CI again)... I think it's better for our patch to add an extra line instead of replacing one, and I think it makes sense to make this consistent with what we do in our main native/android/build.gradle file after D5551.