Page MenuHomePhabricator

[native] Add `jcenter()` as fallback for `gradlePluginPortal()`
ClosedPublic

Authored by atul on Nov 7 2022, 4:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 8:57 PM
Unknown Object (File)
Tue, Nov 19, 8:57 PM
Unknown Object (File)
Tue, Nov 19, 8:57 PM
Unknown Object (File)
Tue, Nov 19, 8:57 PM
Unknown Object (File)
Wed, Nov 13, 8:52 PM
Unknown Object (File)
Wed, Nov 13, 8:45 PM
Unknown Object (File)
Wed, Nov 13, 8:40 PM
Unknown Object (File)
Tue, Nov 12, 5:41 PM
Subscribers

Details

Summary

In a previous diff I removed jcenter() and replaced it with gradlePluginPortal() since jcenter() is (one day) going to be taken down and has been a source of issues in the past.

However... we're now experiencing issues with the Gradle Plugin Portal: https://status.gradle.com/incidents/9j9bx7nlwwf1

I wonder if adding jcenter() as a fallback will resolve things (at least in the short tun)

NOTE: I plan on reverting this in a few days once whatever intermittent Gradle issue is over.
Test Plan

See if Android CI passes

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul requested review of this revision.Nov 7 2022, 5:06 PM
NOTE: I plan on reverting this in a few days once whatever intermittent Gradle issue is over.

Is that a good idea? Seems like this sort of downtime is like a regular thing with these Android package hosts... maybe we keep both of them around just in case? Or does that slow down builds or something?

This revision is now accepted and ready to land.Nov 7 2022, 5:51 PM
NOTE: I plan on reverting this in a few days once whatever intermittent Gradle issue is over.

Is that a good idea? Seems like this sort of downtime is like a regular thing with these Android package hosts... maybe we keep both of them around just in case? Or does that slow down builds or something?

By leaving it off the list we'll be alerted (by a build failure) if some dependency can only be resolved via jcenter() (since TIL Gradle Plugin Portal isn't a "complete" mirror...).

I'll land as-is and we can see how things go w/ Android dependency reliability

In D5551#164527, @atul wrote:
NOTE: I plan on reverting this in a few days once whatever intermittent Gradle issue is over.

Is that a good idea? Seems like this sort of downtime is like a regular thing with these Android package hosts... maybe we keep both of them around just in case? Or does that slow down builds or something?

By leaving it off the list we'll be alerted (by a build failure) if some dependency can only be resolved via jcenter() (since TIL Gradle Plugin Portal isn't a "complete" mirror...).

What do we gain from being alerted in this situation? Won't the fix just be to bring back jcenter()? What's the downside of leaving jcenter() in?