Paths

Table of Contentst

Differential D12967

[lib] Remove community from thick threads
ClosedPublic
Actions

Authored by tomek on Aug 5 2024, 3:24 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 6, 11:33 PM

	Unknown Object (File)
	Wed, Nov 6, 11:33 PM

	Unknown Object (File)
	Wed, Nov 6, 11:33 PM

	Unknown Object (File)
	Wed, Nov 6, 10:34 PM

	Unknown Object (File)
	Sat, Nov 2, 4:57 AM

	Unknown Object (File)
	Sat, Nov 2, 4:57 AM

	Unknown Object (File)
	Sat, Nov 2, 4:56 AM

	Unknown Object (File)
	Sat, Nov 2, 4:37 AM

View All 48 Files

Subscribers

Details

Reviewers

kamil
inka

Commits

rCOMMdf3698446e2f: [lib] Remove community from thick threads

Summary

Thick threads can't have a community.

https://linear.app/comm/issue/ENG-8937/remove-community-from-mutablethickrawthreadinfo

More context D12914.

Test Plan

Made sure that it's possible to create a sidebar. Also checked if persisting and reading thin and thick threads from SQLite works on web.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Aug 5 2024, 3:24 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 5 2024, 3:24 AM

tomek added inline comments.Aug 5 2024, 3:27 AM

lib/utils/thread-ops-utils.js
47 ↗	(On Diff #43067)	This is for Flow. `ClientDBThreadInfo` has `community` as a mandatory nullable property, but thick threads don't have it at all.
native/redux/persist.js
405–427 ↗	(On Diff #43067)	We shouldn't expect any thick thread to be in the store while performing this old migration.

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 5 2024, 3:45 AM

Harbormaster failed remote builds in B30887: Diff 43067!

tomek added a child revision: D12969: [lib] Rename editor to joiner in join thread operation.Aug 5 2024, 3:53 AM

Harbormaster completed remote builds in B30887: Diff 43067.Aug 5 2024, 4:17 AM

tomek requested review of this revision.Aug 5 2024, 4:17 AM

tomek edited the summary of this revision. (Show Details)Aug 5 2024, 6:20 AM

tomek edited the summary of this revision. (Show Details)

inka accepted this revision.Aug 5 2024, 6:23 AM

This revision is now accepted and ready to land.Aug 5 2024, 6:23 AM

Closed by commit rCOMMdf3698446e2f: [lib] Remove community from thick threads (authored by tomek). · Explain WhyAug 6 2024, 3:35 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMdf3698446e2f: [lib] Remove community from thick threads.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

create-thread-spec.js

2 lines

thread-utils.js

1 line

types/

2 lines

thread-types.js

1 line

utils/

thread-ops-utils.js

2 lines

native/

redux/

10 lines

Diff 43168

lib/shared/dm-ops/create-thread-spec.js

Loading...

lib/shared/thread-utils.js

Loading...

lib/types/dm-ops.js

Loading...

lib/types/thread-types.js

Loading...

lib/utils/thread-ops-utils.js

Loading...

native/redux/persist.js

Loading...