Differential D12994

[lib] Add selector to get peers user and device IDs
ClosedPublic
Actions

Authored by bartek on Aug 6 2024, 1:01 AM.

Details

Reviewers

kamil

Commits

rCOMM901f2f5f3fd5: [lib] Add selector to get peers user and device IDs

Summary

Added a selector to conveniently get peers (userID, deviceID) pairs which can be used to e.g. broadcast Olm messages.

Test Plan

Flow. Logic tested later in the stack

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Aug 6 2024, 1:01 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 6 2024, 1:01 AM

bartek added a child revision: D12996: [lib] Use the useBroadcastOlmMessage hook in account deletion.Aug 6 2024, 1:04 AM

Harbormaster completed remote builds in B30949: Diff 43164.Aug 6 2024, 1:17 AM

bartek published this revision for review.Aug 6 2024, 1:35 AM

kamil accepted this revision.Aug 6 2024, 2:44 AM

kamil added inline comments.

lib/selectors/user-selectors.js
263 ↗	(On Diff #43164)	I think this is better but up to you

This revision is now accepted and ready to land.Aug 6 2024, 2:44 AM

Rename according to suggestion

Harbormaster completed remote builds in B30953: Diff 43171.Aug 6 2024, 4:46 AM

Closed by commit rCOMM901f2f5f3fd5: [lib] Add selector to get peers user and device IDs (authored by bartek). · Explain WhyAug 6 2024, 5:18 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM901f2f5f3fd5: [lib] Add selector to get peers user and device IDs.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

user-selectors.js

17 lines

Diff 43171

View Options

lib/selectors/user-selectors.js

[lib] Add selector to get peers user and device IDsClosedPublicActions