Paths

Table of Contentst

-
lib/
-
actions/
-
user-actions.js
-
hooks/
-
peer-list-hooks.js
-
tunnelbroker/
-
use-peer-to-peer-message-handler.js

Differential D12996

[lib] Use the useBroadcastOlmMessage hook in account deletion
ClosedPublic
Actions

Authored by bartek on Aug 6 2024, 1:04 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Mar 3, 3:46 PM

	Unknown Object (File)
	Feb 18 2025, 5:14 AM

	Unknown Object (File)
	Feb 18 2025, 5:14 AM

	Unknown Object (File)
	Feb 18 2025, 5:13 AM

	Unknown Object (File)
	Feb 3 2025, 12:34 PM

	Unknown Object (File)
	Jan 30 2025, 1:53 PM

	Unknown Object (File)
	Jan 26 2025, 12:19 PM

	Unknown Object (File)
	Jan 15 2025, 10:00 AM

View All 85 Files

Subscribers

Details

Reviewers

Commits

rCOMM89096e302465: [lib] Use the useBroadcastOlmMessage hook in account deletion

Summary

Updated useBroadcastAccountDeletion to use the new useBroadcastOlmMessage hook.
Also renamed broadcastToOwnDevices to includeOwnDevices because the old name was confusing.

Depends on D12994, D12995

Test Plan

Repeated test plan from D12944

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Aug 6 2024, 1:04 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 6 2024, 1:04 AM

bartek added a child revision: D12997: [lib] Use the useBroadcastOlmMessage hook in logout actions.Aug 6 2024, 1:06 AM

Harbormaster completed remote builds in B30951: Diff 43166.Aug 6 2024, 1:26 AM

bartek published this revision for review.Aug 6 2024, 1:36 AM

bartek added inline comments.

lib/hooks/peer-list-hooks.js
216–218 ↗	(On Diff #43166)	Previous name was confusing. Default value was also counterintuitive. Opted out of it. Also, addressed https://phab.comm.dev/D12944?id=42964#inline-75242

kamil accepted this revision.Aug 6 2024, 2:47 AM

kamil added inline comments.

lib/hooks/peer-list-hooks.js
216–218 ↗	(On Diff #43166)	nice, I think it's better now

This revision is now accepted and ready to land.Aug 6 2024, 2:47 AM

Rebase on moved hook

Harbormaster completed remote builds in B30955: Diff 43173.Aug 6 2024, 4:53 AM

Closed by commit rCOMM89096e302465: [lib] Use the useBroadcastOlmMessage hook in account deletion (authored by bartek). · Explain WhyAug 6 2024, 5:18 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM89096e302465: [lib] Use the useBroadcastOlmMessage hook in account deletion.

Revision Contents
Changeset List

Path

Size

lib/

actions/

user-actions.js

2 lines

hooks/

peer-list-hooks.js

74 lines

tunnelbroker/

use-peer-to-peer-message-handler.js

2 lines

Diff 43177

lib/actions/user-actions.js

Loading...

lib/hooks/peer-list-hooks.js

Loading...

lib/tunnelbroker/use-peer-to-peer-message-handler.js

Loading...