[lib] Broadcast account deletion message to peers
ClosedPublic
Actions

Authored by bartek on Jul 30 2024, 5:52 AM.

Details

Reviewers

kamil

Commits

rCOMM0e7b20072836: [lib] Broadcast account deletion message to peers

Summary

Address ENG-8605.

Created a hook to easily broadcast deletion message.

In useDeleteAccount hook, added a call to the hook before calling Identity.

Depends on D12943

Test Plan

Tested together with D12945.
Deleted account when having device list with a secondary device and a peer in auxUserStore. Verified that both peer and my device received the ACCOUNT_DELETION message.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jul 30 2024, 5:52 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 30 2024, 5:52 AM

bartek added a child revision: D12945: [lib] Re-broadcast account deletion on own devices.Jul 30 2024, 5:54 AM

Harbormaster completed remote builds in B30814: Diff 42964.Jul 30 2024, 7:00 AM

bartek published this revision for review.Aug 1 2024, 2:01 AM

bartek edited the test plan for this revision. (Show Details)Aug 1 2024, 6:49 AM

Improvements to useBroadcastAccountDeletion hook

bartek added inline comments.Aug 5 2024, 3:23 AM

lib/actions/user-actions.js
536–537 ↗	(On Diff #43066)	This is because of Flow not being able to infer these as non-null after `await broadcastAccountDeletion();` was called

Harbormaster failed remote builds in B30886: Diff 43066!Aug 5 2024, 3:44 AM

kamil accepted this revision.Aug 5 2024, 4:33 AM

kamil added inline comments.

lib/hooks/peer-list-hooks.js
180–182 ↗	(On Diff #43066)	Thinking that we should prioritize this: ENG-8192 to avoid remembering about this each time.
183–220 ↗	(On Diff #43066)	I think this is some code duplication, can be extracted to a separate hook to reuse this each time. Can be done as a follow-up.
144