Details
Details
- Reviewers
kamil - Commits
- rCOMM0e7b20072836: [lib] Broadcast account deletion message to peers
Tested together with D12945.
Deleted account when having device list with a secondary device and a peer in auxUserStore. Verified that both peer and my device received the ACCOUNT_DELETION message.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
lib/actions/user-actions.js | ||
---|---|---|
536–537 ↗ | (On Diff #43066) | This is because of Flow not being able to infer these as non-null after await broadcastAccountDeletion(); was called |
lib/hooks/peer-list-hooks.js | ||
---|---|---|
180–182 ↗ | (On Diff #43066) | Thinking that we should prioritize this: ENG-8192 to avoid remembering about this each time. |
183–220 ↗ | (On Diff #43066) | I think this is some code duplication, can be extracted to a separate hook to reuse this each time. Can be done as a follow-up. |
144 ↗ | (On Diff #42964) |
lib/hooks/peer-list-hooks.js | ||
---|---|---|
183–220 ↗ | (On Diff #43066) | I'll address this in a separate diff |
lib/hooks/peer-list-hooks.js | ||
---|---|---|
149 | This feedback was not addressed |