Page MenuHomePhabricator
Differential D12996

[lib] Use the useBroadcastOlmMessage hook in account deletion
ClosedPublic
Actions

Authored by bartek on Aug 6 2024, 1:04 AM.
Tags
None
Referenced Files
F3332713: D12996.id43173.diff
Thu, Nov 21, 1:15 AM
F3332700: D12996.id43177.diff
Thu, Nov 21, 1:14 AM
Unknown Object (File)
Sun, Nov 10, 3:08 AM
Unknown Object (File)
Sat, Nov 9, 4:39 PM
Unknown Object (File)
Wed, Nov 6, 10:34 PM
Unknown Object (File)
Sat, Nov 2, 3:38 AM
Unknown Object (File)
Sat, Nov 2, 3:37 AM
Unknown Object (File)
Sat, Nov 2, 3:36 AM
View All 67 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
Commits
rCOMM89096e302465: [lib] Use the useBroadcastOlmMessage hook in account deletion
Summary

Updated useBroadcastAccountDeletion to use the new useBroadcastOlmMessage hook.
Also renamed broadcastToOwnDevices to includeOwnDevices because the old name was confusing.

Depends on D12994, D12995

Test Plan

Repeated test plan from D12944

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Aug 6 2024, 1:04 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 6 2024, 1:04 AM
bartek added a child revision: D12997: [lib] Use the useBroadcastOlmMessage hook in logout actions.Aug 6 2024, 1:06 AM
Harbormaster completed remote builds in B30951: Diff 43166.Aug 6 2024, 1:26 AM
bartek published this revision for review.Aug 6 2024, 1:36 AM
bartek added inline comments.
lib/hooks/peer-list-hooks.js
216–218
kamil accepted this revision.Aug 6 2024, 2:47 AM
kamil added inline comments.
lib/hooks/peer-list-hooks.js
216–218

nice, I think it's better now

This revision is now accepted and ready to land.Aug 6 2024, 2:47 AM
bartek updated this revision to Diff 43173.Aug 6 2024, 4:30 AM

Rebase on moved hook

Harbormaster completed remote builds in B30955: Diff 43173.Aug 6 2024, 4:53 AM
Closed by commit rCOMM89096e302465: [lib] Use the useBroadcastOlmMessage hook in account deletion (authored by bartek). · Explain WhyAug 6 2024, 5:18 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM89096e302465: [lib] Use the useBroadcastOlmMessage hook in account deletion.

Revision Contents
Changeset List

PathSize
lib/
actions/
2 lines
hooks/
71 lines
tunnelbroker/
2 lines

Diff 43166

View Options

lib/actions/user-actions.js

Loading...
View Options

lib/hooks/peer-list-hooks.js

Loading...
View Options

lib/tunnelbroker/use-peer-to-peer-message-handler.js

Loading...