Page MenuHomePhabricator

[native] Add jcenter() as a fallback in our react-native-ffmpeg patch
ClosedPublic

Authored by ashoat on Aug 5 2024, 2:13 PM.
Tags
None
Referenced Files
F3332716: D12992.id43188.diff
Thu, Nov 21, 1:15 AM
F3332697: D12992.id43193.diff
Thu, Nov 21, 1:14 AM
Unknown Object (File)
Sun, Nov 10, 9:29 PM
Unknown Object (File)
Sun, Nov 10, 11:47 AM
Unknown Object (File)
Oct 19 2024, 8:24 AM
Unknown Object (File)
Oct 18 2024, 9:44 PM
Unknown Object (File)
Oct 18 2024, 9:44 PM
Unknown Object (File)
Oct 18 2024, 9:44 PM
Subscribers

Details

Summary

This resolves ENG-8959, an issue where our Android build is failing down to intermittent downtime from gradlePluginPortal() preventing us from downloading artifacts necessary for react-native-ffmpeg.

gradlePluginPortal() is a mirror of jcenter(). We switched from jcenter() to it due to intermittent JCenter downtime in D5510. We later reintroduced jcenter() as a fallback for our main native/android/build.gradle Gradle file in D5551, but we failed to reintroduce the jcenter() fallback for our react-native-ffmpeg patch.

This diff introduces the jcenter() fallback for our react-native-ffmpeg patch.

Test Plan
  1. On my local machine, the Android build got past the part that was failing
  2. I will make sure Buildkite CI passes before landing

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/android
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat published this revision for review.Aug 5 2024, 2:14 PM

Requesting review, but will wait on Android CI before landing

patches/react-native-ffmpeg+0.4.4.patch
13 ↗(On Diff #43159)

Not sure why this change occurred. I didn't manually touch the file (just ran patch-package). Guessing somebody previously accidentally added the newline, and it didn't break patch-package so it wasn't noticed

This revision is now accepted and ready to land.Aug 5 2024, 2:14 PM

The issue appeared to have gone away (see here). I'm going to go ahead and land this anyways (after checking CI again)... I think it's better for our patch to add an extra line instead of replacing one, and I think it makes sense to make this consistent with what we do in our main native/android/build.gradle file after D5551.