This differential ensures that Comm Windows application data are deleted after uninstalling the app.
Details
Details
- Build Windows app.
- Uninstall it.
- Ensure AppData/Roaming/Comm folder is empty. Without this diff it would have all the data.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- marcin/eng-8934
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| desktop/flow-typed/npm/electron_v22.0.0.js | ||
|---|---|---|
| 15–32 ↗ | (On Diff #43194) | Options are listed in the docs |
| 426–430 ↗ | (On Diff #43194) | This module is documented here. Proceeded with unexact type to get the diff faster. |
| desktop/src/handle-squirrel-event.js | ||
| 25 ↗ | (On Diff #43194) | In src/main.js we call this at the very beginning of run method. It makes app store data under AppData/Roaming/Comm path. But in this script app.getPath method would return AppData/Roaming/desktop since that is how we name our app in package.json. Therefore I call app.setName('Comm') to get the right path from app.getPath(). Some context here |
| 41–46 ↗ | (On Diff #43194) | This will be Windows-style error message dialogue window that the user will see if folder deletion will fail. That is why @ashoat is a blocking reviewer. |