This differential implements notificationsCreationData for send-text-message-spec. Now calling sendDMOperation will result in sending e2ee notifs to thick thread members
Details
Details
- Apply this small patch: https://gist.github.com/marcinwasowicz/6b3087442043ae46e612a0cae89ff7b2 - only modify thick thread selector to return normal thread and call sendDMOperation from input bar on web and native.
- Send messages back and forth. Each message should result in two notifications looking the same
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- marcin/eng-8237
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/shared/dm-ops/send-text-message-spec.js | ||
|---|---|---|
| 76–83 | Is there duplication here? I can see similar code in lines 24-31. In this case there is hardly any duplication, since the code is so simple. But for other specs, I could imagine more duplication. I wonder if this should be factored out. It could either be factored out as an implementation detail (eg. each spec has it factored out as a convention), or as a hard rule (all message specs must implement a function that goes from dmOp to MessageData). | |
| lib/shared/dm-ops/send-text-message-spec.js | ||
|---|---|---|
| 76–83 | If you take a look at the very next diff you will see that even though MessageData are created both in processDMOperation and notificationsCreationData the detailed logic is different somehow and there is no straightforward way to factor the code out. | |
| lib/shared/dm-ops/send-text-message-spec.js | ||
|---|---|---|
| 76–83 | We can follow up in that diff, but I don't understand why the logic should be different | |