Page MenuHomePhabricator
Differential D13041

[lib] Don't check relyingOnAuthoritativeKeyserver when reducing removePeerUsersActionType
ClosedPublic
Actions

Authored by ashoat on Aug 10 2024, 12:23 PM.
Tags
None
Referenced Files
F3345788: D13041.diff
Fri, Nov 22, 7:01 AM
Unknown Object (File)
Wed, Nov 20, 2:45 AM
Unknown Object (File)
Wed, Nov 20, 2:44 AM
Unknown Object (File)
Wed, Nov 20, 2:44 AM
Unknown Object (File)
Wed, Nov 20, 2:43 AM
Unknown Object (File)
Sat, Nov 9, 11:58 PM
Unknown Object (File)
Sat, Nov 2, 4:44 AM
Unknown Object (File)
Sat, Nov 2, 4:44 AM
View All 41 Files
Subscribers
bartek
tomek

Details

Reviewers
inka
kamil
bartek
Commits
rCOMMf19c0309b397: [lib] Don't check relyingOnAuthoritativeKeyserver when reducing…
Summary

There was some ambiguous feedback in D12962 – @bartek interpreted that this check should be left, but I interpreted that it should be removed.

My intuition is that we should reduce UserStore and AuxUserStore under the same conditions. Curious for other reviewers' take.

Test Plan

I haven't tested this. If reviewers think it needs to be tested, I would appreciate @bartek's help on that, as he wrote the initial diff and has context on how to test

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/media
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Aug 10 2024, 12:23 PM
Herald added a subscriber: tomek. · View Herald TranscriptAug 10 2024, 12:23 PM
Harbormaster completed remote builds in B31032: Diff 43293.Aug 10 2024, 12:40 PM
ashoat requested review of this revision.Aug 10 2024, 12:40 PM
ashoat mentioned this in D12962: [lib] Add action type to remove peer user.Aug 10 2024, 1:58 PM
kamil accepted this revision.Aug 12 2024, 8:02 AM

In my review, I meant that this check should be removed

My intuition is that we should reduce UserStore and AuxUserStore under the same conditions. Curious for other reviewers' take.

Agree with that

This revision is now accepted and ready to land.Aug 12 2024, 8:02 AM
Closed by commit rCOMMf19c0309b397: [lib] Don't check relyingOnAuthoritativeKeyserver when reducing… (authored by ashoat). · Explain WhyAug 12 2024, 8:14 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMf19c0309b397: [lib] Don't check relyingOnAuthoritativeKeyserver when reducing….

Revision Contents
Changeset List

PathSize
lib/
reducers/
5 lines

Diff 43293

View Options

lib/reducers/user-reducer.js

Loading...