Page MenuHomePhabricator

[identity] Verify UpdateDeviceList RPC is called by primary device
ClosedPublic

Authored by bartek on Aug 11 2024, 3:13 AM.
Tags
None
Referenced Files
F2773510: D13042.id43444.diff
Fri, Sep 20, 2:33 AM
F2772200: D13042.diff
Fri, Sep 20, 12:40 AM
Unknown Object (File)
Wed, Sep 18, 12:35 PM
Unknown Object (File)
Wed, Sep 18, 7:36 AM
Unknown Object (File)
Mon, Sep 16, 8:13 AM
Unknown Object (File)
Mon, Sep 16, 3:16 AM
Unknown Object (File)
Mon, Sep 16, 3:16 AM
Unknown Object (File)
Sun, Sep 15, 9:06 AM
Subscribers

Details

Summary

Addresses ENG-8549.
The only place with missing check was UpdateDeviceList.

Test Plan
  • Had user with two mobile devices (primary and secondary)
  • Called the RPC with different auth metadata - switched device_id metadata between primary and secondary
  • The RPC accepted request from primary device and rejected from the secondary.

Note that the RPC can also reject requests because of invalid signature so it's good to test it without signatures.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage