Page MenuHomePhabricator

[native] Select logout flow basing on being primary device
ClosedPublic

Authored by bartek on Aug 11 2024, 3:19 AM.
Tags
None
Referenced Files
F3387237: D13044.id43296.diff
Fri, Nov 29, 8:24 AM
Unknown Object (File)
Mon, Nov 25, 8:32 PM
Unknown Object (File)
Mon, Nov 25, 8:19 PM
Unknown Object (File)
Wed, Nov 20, 9:30 PM
Unknown Object (File)
Wed, Nov 20, 9:30 PM
Unknown Object (File)
Sun, Nov 10, 12:17 AM
Unknown Object (File)
Sat, Nov 9, 10:02 PM
Unknown Object (File)
Fri, Nov 8, 11:06 PM
Subscribers

Details

Summary

Address ENG-8550.

  • Merged two dev "new flow logout" buttons into one
  • Added new selector to get primary device
Test Plan
  • Created a user, logged in on two mobile devices
  • Confirmed that pressing the button on secondary logs out only itself (secondary device logout)
  • Confirmed that pressing the button on the primary logs out both (primary device logout)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Aug 12 2024, 12:09 AM

I need to be set as a blocking reviewer for any diff with copy. Please remember this going forward.

ashoat added inline comments.
native/profile/profile-screen.react.js
392

Let's change this to "Log out all devices?"

Please include the question mark

393

Let's change this to:

This device is your primary device, so logging out will cause all of your other devices to log out too.

396–397
This revision is now accepted and ready to land.Aug 12 2024, 6:54 AM