Paths

Table of Contentst

Implement utilities to go from RawMessageInfo to MessageData
AbandonedPublic
Actions

Authored by marcin on Aug 12 2024, 6:49 AM.

Details

Reviewers

tomek
kamil
inka
ashoat

Summary

This differential extends message specs with function that go from RawMessageinfos to MessageData

Test Plan

Flow. The top of this stack will use those functions

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Aug 12 2024, 6:49 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 12 2024, 6:49 AM

marcin added a parent revision: D13010: Update db ops reducer to process notiications creation data.Aug 12 2024, 6:49 AM

marcin added a child revision: D13050: Extract logic of pushInfo -> usersToCollapsableNotifInfo to lib and use for client-based notifs.Aug 12 2024, 6:53 AM

Harbormaster completed remote builds in B31044: Diff 43308.Aug 12 2024, 7:39 AM

marcin requested review of this revision.Aug 12 2024, 7:39 AM

Why are we doing this? Shouldn't we start with MessageData, and go from there to RawMessageInfo? Why do we need additional functionality to go from RawMessageInfo -> MessageData?

This revision now requires changes to proceed.Aug 12 2024, 8:00 AM

marcin abandoned this revision.Aug 20 2024, 7:31 AM

marcin removed a parent revision: D13010: Update db ops reducer to process notiications creation data.

marcin removed a child revision: D13050: Extract logic of pushInfo -> usersToCollapsableNotifInfo to lib and use for client-based notifs.

Revision Contents
Changeset List

Path

Size

lib/

shared/

message-utils.js

12 lines

messages/

add-members-message-spec.js

7 lines

change-role-message-spec.js

7 lines

change-settings-message-spec.js

7 lines

create-entry-message-spec.js

7 lines

create-sidebar-message-spec.js

7 lines

create-sub-thread-message-spec.js

7 lines

create-thread-message-spec.js

7 lines

delete-entry-message-spec.js

7 lines

edit-entry-message-spec.js

7 lines

edit-message-spec.js

7 lines

join-thread-message-spec.js

7 lines

leave-thread-message-spec.js

7 lines

message-spec.js

1 line

multimedia-message-spec.js

7 lines

reaction-message-spec.js

7 lines

remove-members-message-spec.js

7 lines

restore-entry-message-spec.js

7 lines

sidebar-source-message-spec.js

7 lines

text-message-spec.js

7 lines

toggle-pin-message-spec.js

7 lines

update-relationship-message-spec.js

9 lines

Diff 43308

View Options

lib/shared/message-utils.js

View Options

lib/shared/messages/add-members-message-spec.js

View Options

lib/shared/messages/change-role-message-spec.js

View Options

lib/shared/messages/change-settings-message-spec.js

View Options

lib/shared/messages/create-entry-message-spec.js

View Options

lib/shared/messages/create-sidebar-message-spec.js

View Options

lib/shared/messages/create-sub-thread-message-spec.js

View Options

lib/shared/messages/create-thread-message-spec.js

View Options

lib/shared/messages/delete-entry-message-spec.js

View Options

lib/shared/messages/edit-entry-message-spec.js

View Options

lib/shared/messages/edit-message-spec.js

View Options

lib/shared/messages/join-thread-message-spec.js

View Options

lib/shared/messages/leave-thread-message-spec.js

View Options

lib/shared/messages/message-spec.js

View Options

lib/shared/messages/multimedia-message-spec.js

View Options

lib/shared/messages/reaction-message-spec.js

View Options

lib/shared/messages/remove-members-message-spec.js

View Options

lib/shared/messages/restore-entry-message-spec.js

View Options

lib/shared/messages/sidebar-source-message-spec.js

View Options

lib/shared/messages/text-message-spec.js

View Options

lib/shared/messages/toggle-pin-message-spec.js

View Options

lib/shared/messages/update-relationship-message-spec.js

Implement utilities to go from RawMessageInfo to MessageDataAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43308

lib/shared/message-utils.js

lib/shared/messages/add-members-message-spec.js

lib/shared/messages/change-role-message-spec.js

lib/shared/messages/change-settings-message-spec.js

lib/shared/messages/create-entry-message-spec.js

lib/shared/messages/create-sidebar-message-spec.js

lib/shared/messages/create-sub-thread-message-spec.js

lib/shared/messages/create-thread-message-spec.js

lib/shared/messages/delete-entry-message-spec.js

lib/shared/messages/edit-entry-message-spec.js

lib/shared/messages/edit-message-spec.js

lib/shared/messages/join-thread-message-spec.js

lib/shared/messages/leave-thread-message-spec.js

lib/shared/messages/message-spec.js

lib/shared/messages/multimedia-message-spec.js

lib/shared/messages/reaction-message-spec.js

lib/shared/messages/remove-members-message-spec.js

lib/shared/messages/restore-entry-message-spec.js

lib/shared/messages/sidebar-source-message-spec.js

lib/shared/messages/text-message-spec.js

lib/shared/messages/toggle-pin-message-spec.js

lib/shared/messages/update-relationship-message-spec.js

Implement utilities to go from RawMessageInfo to MessageData
AbandonedPublic
Actions

Revision Contents
Changeset List