Paths

Table of Contentst

[lib] allow to overwrite content session
ClosedPublic
Actions

Authored by kamil on Aug 8 2024, 3:12 AM.

Details

Reviewers

marcin
tomek

Commits

rCOMM1f4ac2c550d8: [lib] allow to overwrite content session

Summary

ENG-6982.

When discovering session is malformed we want to create a new one (and resend messages, implemented later in the stack).

initializeContentOutboundSession implementation allow to override session by default.

Test Plan

Being able to create new session even if one already exists

Diff Detail

Repository

rCOMM Comm

Branch

land

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Aug 8 2024, 3:12 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 8 2024, 3:12 AM

kamil published this revision for review.Aug 8 2024, 3:22 AM

kamil added a child revision: D13025: [web][native] unify errors from `CryptoModule` on web and native.Aug 8 2024, 3:31 AM

Harbormaster failed remote builds in B31003: Diff 43252!Aug 8 2024, 3:34 AM

ashoat added inline comments.Aug 8 2024, 6:07 AM

lib/utils/crypto-utils.js
112 ↗	(On Diff #43252)	Typo

tomek accepted this revision.Aug 9 2024, 2:25 AM

This revision is now accepted and ready to land.Aug 9 2024, 2:25 AM

fix typo

Harbormaster completed remote builds in B31051: Diff 43318.Aug 12 2024, 9:24 AM

Closed by commit rCOMM1f4ac2c550d8: [lib] allow to overwrite content session (authored by kamil). · Explain WhyAug 13 2024, 2:29 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM1f4ac2c550d8: [lib] allow to overwrite content session.

Revision Contents
Changeset List

Path

Size

lib/

components/

peer-olm-session-creator-provider.react.js

13 lines

utils/

crypto-utils.js

19 lines

Diff 43318

View Options

lib/components/peer-olm-session-creator-provider.react.js