Page MenuHomePhabricator

[web][native] unify errors from `CryptoModule` on web and native
ClosedPublic

Authored by kamil on Aug 8 2024, 3:31 AM.
Tags
None
Referenced Files
F3193571: D13025.id43319.diff
Fri, Nov 8, 11:05 PM
F3185002: D13025.id43324.diff
Fri, Nov 8, 12:24 PM
Unknown Object (File)
Tue, Oct 22, 6:29 PM
Unknown Object (File)
Fri, Oct 18, 5:15 PM
Unknown Object (File)
Fri, Oct 18, 11:16 AM
Unknown Object (File)
Thu, Oct 17, 9:41 PM
Unknown Object (File)
Sun, Oct 13, 10:03 AM
Unknown Object (File)
Sun, Oct 13, 12:16 AM
Subscribers

Details

Summary

ENG-6982.

ENG-8333.

To avoid declaring the same constant between two platforms created ENG-8995

Depends on D13024

Test Plan

Verify that the proper error is thrown.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Aug 8 2024, 3:39 AM
tomek added inline comments.
native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp
17 ↗(On Diff #43253)

Maybe SESSION_DOESNT_EXIST?

web/shared-worker/worker/worker-crypto.js
558 ↗(On Diff #43253)

Do we need this log?

This revision is now accepted and ready to land.Aug 9 2024, 2:37 AM
lib/utils/olm-utils.js
135

Why "Exists" and not "Exist"? (I think there's a typo here, for both key and value)

lib/utils/olm-utils.js
135

Right, going to put up a diff for it

lib/utils/olm-utils.js
135

Don't think this ever got done. Can you create a task for it?

lib/utils/olm-utils.js
135

D13171 is up, and it is going to land soon.

I wasn't adding any additional comments because it's visible in this revision here that there is a related diff.

lib/utils/olm-utils.js
135

Thanks for explaining, and sorry I missed that!