Paths

Table of Contentst

Differential D13025

[web][native] unify errors from `CryptoModule` on web and native
ClosedPublic
Actions

Authored by kamil on Aug 8 2024, 3:31 AM.

Tags

None

Referenced Files

	F3003909: D13025.id43253.diff
	Fri, Oct 18, 11:16 AM

	F2998945: D13025.id43253.diff
	Thu, Oct 17, 9:41 PM

	Unknown Object (File)
	Sun, Oct 13, 10:03 AM

	Unknown Object (File)
	Sun, Oct 13, 12:16 AM

	Unknown Object (File)
	Thu, Oct 10, 11:49 PM

	Unknown Object (File)
	Thu, Oct 10, 12:49 PM

	Unknown Object (File)
	Sun, Oct 6, 9:42 PM

	Unknown Object (File)
	Fri, Oct 4, 4:45 AM

View All 42 Files

Subscribers

Details

Reviewers

marcin
tomek

Commits

rCOMM037276f8296f: [web][native] unify errors from `CryptoModule` on web and native

Summary

To avoid declaring the same constant between two platforms created ENG-8995

Depends on D13024

Test Plan

Verify that the proper error is thrown.

Diff Detail

Repository

Branch

land

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Aug 8 2024, 3:31 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 8 2024, 3:31 AM

kamil published this revision for review.Aug 8 2024, 3:39 AM

Harbormaster failed remote builds in B31004: Diff 43253!Aug 8 2024, 3:54 AM

kamil edited the test plan for this revision. (Show Details)Aug 8 2024, 4:05 AM

kamil added a child revision: D13027: [lib] create session with peer only when it is missing.Aug 8 2024, 4:06 AM

tomek accepted this revision.Aug 9 2024, 2:37 AM

tomek added inline comments.

native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp
17 ↗	(On Diff #43253)	Maybe `SESSION_DOESNT_EXIST`?
web/shared-worker/worker/worker-crypto.js
558 ↗	(On Diff #43253)	Do we need this log?

This revision is now accepted and ready to land.Aug 9 2024, 2:37 AM

address review

Harbormaster completed remote builds in B31052: Diff 43319.Aug 12 2024, 9:39 AM

Closed by commit rCOMM037276f8296f: [web][native] unify errors from `CryptoModule` on web and native (authored by kamil). · Explain WhyAug 13 2024, 2:29 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM037276f8296f: [web][native] unify errors from `CryptoModule` on web and native.

ashoat added inline comments.Aug 13 2024, 5:22 AM

lib/utils/olm-utils.js
135 ↗	(On Diff #43324)	Why "Exists" and not "Exist"? (I think there's a typo here, for both key and value)

kamil added inline comments.Aug 21 2024, 2:13 AM

lib/utils/olm-utils.js
135 ↗	(On Diff #43324)	Right, going to put up a diff for it

kamil mentioned this in D13171: [lib][web][native] rename `SESSION_DOES_NOT_EXISTS` -> `SESSION_DOES_NOT_EXIST`.Aug 26 2024, 9:09 AM

ashoat added inline comments.Sep 5 2024, 10:41 AM

lib/utils/olm-utils.js
135 ↗	(On Diff #43324)	Don't think this ever got done. Can you create a task for it?

kamil added inline comments.Sep 6 2024, 1:06 AM

lib/utils/olm-utils.js
135 ↗	(On Diff #43324)	D13171 is up, and it is going to land soon. I wasn't adding any additional comments because it's visible in this revision here that there is a related diff.

kamil mentioned this in rCOMM309ecba81d40: [lib][web][native] rename `SESSION_DOES_NOT_EXISTS` -> `SESSION_DOES_NOT_EXIST`.Sep 6 2024, 1:51 AM

ashoat added inline comments.Sep 9 2024, 5:13 AM

lib/utils/olm-utils.js
135 ↗	(On Diff #43324)	Thanks for explaining, and sorry I missed that!

Revision Contents
Changeset List

Path

Size

lib/

utils/

6 lines

native/

cpp/

CommonCpp/

CryptoTools/

CryptoModule.cpp

8 lines

web/

shared-worker/

worker/

worker-crypto.js

8 lines

Diff 43319

lib/utils/olm-utils.js

Loading...

native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp

Loading...

web/shared-worker/worker/worker-crypto.js

Loading...