Page MenuHomePhabricator

[terraform] Disable traffic after terraform apply and reenable after health check
ClosedPublic

Authored by will on Aug 14 2024, 1:50 PM.
Tags
None
Referenced Files
F3368319: D13088.diff
Mon, Nov 25, 7:16 PM
Unknown Object (File)
Fri, Nov 22, 2:15 PM
Unknown Object (File)
Fri, Nov 22, 2:05 PM
Unknown Object (File)
Wed, Nov 20, 2:07 PM
Unknown Object (File)
Wed, Nov 20, 2:06 PM
Unknown Object (File)
Sat, Nov 9, 11:49 PM
Unknown Object (File)
Fri, Nov 8, 10:06 AM
Unknown Object (File)
Tue, Nov 5, 10:04 PM
Subscribers

Details

Summary

In https://phab.comm.dev/rCOMMbf5cae4c208a9e0759e031d1189e6cab0a3a2812, I remove the unnecessary reenabling of ingress rules. However, I'm realizing now that having terraform apply run and restore general access right before the health check defeats the purpose of disabling general access in the first place.

The health check needs to always be able to access the keyserver, but could be lost in general traffic. Adding commands to disable general access right after terraform apply and adding back commands to restore access after health check

Test Plan

Ran the deploy script. Ingress rules are properly restored

Diff Detail

Repository
rCOMM Comm
Branch
fix_ingress_disable
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will retitled this revision from [terraform] Disable traffic after terraform apply and reenable after h ealth check to [terraform] Disable traffic after terraform apply and reenable after health check.Aug 14 2024, 1:51 PM
will edited the summary of this revision. (Show Details)
will requested review of this revision.Aug 14 2024, 2:07 PM
This revision is now accepted and ready to land.Aug 14 2024, 7:34 PM