Page MenuHomePhabricator
Differential D13108

[SQLite] enable DB on web for all users
ClosedPublic
Actions

Authored by kamil on Aug 19 2024, 5:48 AM.
Tags
None
Referenced Files
F2842350: D13108.id43451.diff
Sun, Sep 29, 1:27 PM
F2842340: D13108.id43493.diff
Sun, Sep 29, 1:26 PM
F2841726: D13108.diff
Sun, Sep 29, 11:11 AM
Unknown Object (File)
Wed, Sep 25, 1:30 AM
Unknown Object (File)
Wed, Sep 25, 1:30 AM
Unknown Object (File)
Wed, Sep 25, 12:26 AM
Unknown Object (File)
Mon, Sep 9, 9:12 AM
Unknown Object (File)
Mon, Sep 9, 5:53 AM
View All 34 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
marcin
Commits
rCOMMf022b32a30c9: [SQLite] enable DB on web for all users
Summary

ENG-8075.

Removing canUseDatabaseOnWeb.

Test Plan
  1. Make canUseDatabaseOnWeb return false and use the app (data is returned from the keyserver).
  2. Apply this diff
  3. Refresh first time: data is returned from the keyserver but ops are processed on DB.
  4. Refresh a second time: data is not returned from the keyserver but read from DB.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Aug 19 2024, 5:48 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptAug 19 2024, 5:48 AM
kamil added a child revision: D13109: [lib][native] unify `DBOpsHandler` usage.Aug 19 2024, 5:49 AM
kamil edited the summary of this revision. (Show Details)Aug 19 2024, 5:56 AM
kamil edited the test plan for this revision. (Show Details)
kamil added inline comments.
web/components/db-ops-handler.react.js
11–13

this is improved later in the stack

kamil published this revision for review.Aug 19 2024, 6:05 AM
Harbormaster completed remote builds in B31138: Diff 43451.Aug 19 2024, 6:08 AM
tomek accepted this revision.Aug 20 2024, 1:42 AM
This revision is now accepted and ready to land.Aug 20 2024, 1:42 AM
Closed by commit rCOMMf022b32a30c9: [SQLite] enable DB on web for all users (authored by kamil). · Explain WhyAug 20 2024, 3:32 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMf022b32a30c9: [SQLite] enable DB on web for all users.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
17 lines
lib/
shared/
web/
components/
6 lines
redux/
37 lines
shared-worker/
utils/
32 lines

Diff 43451

View Options

keyserver/src/responders/redux-state-responders.js

Loading...
View Options

lib/shared/web-database.js

Loading...
View Options

web/components/db-ops-handler.react.js

Loading...
View Options

web/redux/initial-state-gate.js

Loading...
View Options

web/shared-worker/utils/store.js

Loading...