Page MenuHomePhabricator

Re-throw all exceptions except from race condition between workers
ClosedPublic

Authored by marcin on Aug 19 2024, 10:34 AM.
Tags
None
Referenced Files
F3558393: D13116.id43487.diff
Fri, Dec 27, 2:23 AM
F3543930: D13116.diff
Thu, Dec 26, 11:41 AM
Unknown Object (File)
Sat, Dec 7, 8:53 AM
Unknown Object (File)
Wed, Nov 27, 3:33 AM
Unknown Object (File)
Nov 8 2024, 7:03 PM
Unknown Object (File)
Nov 8 2024, 7:03 PM
Unknown Object (File)
Nov 8 2024, 7:03 PM
Unknown Object (File)
Nov 8 2024, 7:03 PM
Subscribers
None

Details

Summary

This differntial modifies localforage to provide method to get message of exception that is thrown when race condition occurs. Additionally this method is used innotifs code to filter exception and decide when to silence and when to re-throw exception.

Test Plan
  1. Apply this patch: https://gist.github.com/marcinwasowicz/4aaa7ecc71af0e91c66cf96e748161c0
  2. Uncomment the first change. Youd should be seeing logs in shared worker console but no errors being thrown.
  3. Comment the first change and uncomment the second. You should be seeing errors thrown in web app console.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil added inline comments.
patches/localforage+1.10.0.patch
330 ↗(On Diff #43467)

not sure what is the best, but previous was confusing

This revision is now accepted and ready to land.Aug 20 2024, 1:38 AM