The whole context is in the issue description: https://linear.app/comm/issue/ENG-9059/detect-browser-doesnt-work-when-safari-is-closed
Details
Details
- Kill Safari.
- Ensure keyserver e2e notifs work correctly.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- marcin/eng-9059
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Shouldn't we update all usages of isDesktopSafari that could be affected, e.g. in getCryptoKeyPersistentForm?
Comment Actions
This is a very good question.
For keyserver based notifs it is not necessary to update getCryptoKeyPersistentForm since olm session encryption key is not persisted upon decryption. It is only persisted when session with keyserver is created and this requires opened app. Things are different for peer-to-peer notifications since notification can initiate encryption key generation and persistence since it can be session creation request.
I will continue investigation on Linear.