Page MenuHomePhabricator

Fix broken E2E notifications when Safari is closed
ClosedPublic

Authored by marcin on Aug 20 2024, 3:06 AM.
Tags
None
Referenced Files
F3395833: D13119.id43502.diff
Sun, Dec 1, 8:04 AM
Unknown Object (File)
Fri, Nov 29, 12:32 AM
Unknown Object (File)
Thu, Nov 28, 9:33 PM
Unknown Object (File)
Fri, Nov 8, 7:03 PM
Unknown Object (File)
Fri, Nov 8, 7:03 PM
Unknown Object (File)
Fri, Nov 8, 7:03 PM
Unknown Object (File)
Fri, Nov 8, 7:03 PM
Unknown Object (File)
Fri, Nov 8, 7:01 PM
Subscribers

Details

Summary
Test Plan
  1. Kill Safari.
  2. Ensure keyserver e2e notifs work correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Shouldn't we update all usages of isDesktopSafari that could be affected, e.g. in getCryptoKeyPersistentForm?

This revision is now accepted and ready to land.Aug 20 2024, 3:41 AM

Shouldn't we update all usages of isDesktopSafari that could be affected, e.g. in getCryptoKeyPersistentForm?

This is a very good question.
For keyserver based notifs it is not necessary to update getCryptoKeyPersistentForm since olm session encryption key is not persisted upon decryption. It is only persisted when session with keyserver is created and this requires opened app. Things are different for peer-to-peer notifications since notification can initiate encryption key generation and persistence since it can be session creation request.

I will continue investigation on Linear.