[native][web] Fix crash due to getConfig being called before ready
ClosedPublic
Actions

Authored by ashoat on Aug 22 2024, 1:03 PM.

Tags

None

Referenced Files

	F3374405: D13143.id43594.diff
	Tue, Nov 26, 3:26 PM

	F3374039: D13143.diff
	Tue, Nov 26, 1:25 PM

	Unknown Object (File)
	Fri, Nov 8, 7:03 PM

	Unknown Object (File)
	Fri, Nov 8, 7:03 PM

	Unknown Object (File)
	Fri, Nov 8, 7:01 PM

	Unknown Object (File)
	Oct 22 2024, 10:44 PM

	Unknown Object (File)
	Oct 19 2024, 2:32 PM

	Unknown Object (File)
	Oct 18 2024, 8:57 PM

View All 33 Files

Subscribers

tomek

Details

Reviewers

varun
will

Commits

rCOMM2ac10ed878f2: [native][web] Fix crash due to getConfig being called before ready

Summary

This addresses ENG-9092; additional context there.

Test Plan

Confirmed the problem went away

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Aug 22 2024, 1:03 PM

Herald added a subscriber: tomek. · View Herald TranscriptAug 22 2024, 1:03 PM

ashoat published this revision for review.Aug 22 2024, 1:04 PM

varun accepted this revision.Aug 22 2024, 1:05 PM

This revision is now accepted and ready to land.Aug 22 2024, 1:05 PM

Harbormaster completed remote builds in B31223: Diff 43594.Aug 22 2024, 1:21 PM

Closed by commit rCOMM2ac10ed878f2: [native][web] Fix crash due to getConfig being called before ready (authored by ashoat). · Explain WhyAug 22 2024, 1:50 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM2ac10ed878f2: [native][web] Fix crash due to getConfig being called before ready.

Revision Contents
Changeset List

Path

Size

native/

qr-code/

qr-code-screen.react.js

5 lines

web/

account/

qr-code-login.react.js

5 lines

Diff 43595

View Options

native/qr-code/qr-code-screen.react.js