Differential D13196

[lib] Update thread and keyserver ID regex
ClosedPublic
Actions

Authored by tomek on Aug 28 2024, 8:20 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mar 1 2025, 7:36 PM

	Unknown Object (File)
	Feb 11 2025, 1:49 AM

	Unknown Object (File)
	Jan 15 2025, 7:38 AM

	Unknown Object (File)
	Jan 11 2025, 2:16 AM

	Unknown Object (File)
	Dec 18 2024, 1:31 PM

	Unknown Object (File)
	Dec 18 2024, 1:31 PM

	Unknown Object (File)
	Dec 18 2024, 1:31 PM

	Unknown Object (File)
	Dec 18 2024, 1:31 PM

View All 44 Files

Subscribers

Details

Reviewers

kamil
inka

Commits

rCOMM63f1eda390fd: [lib] Update thread and keyserver ID regex

Summary

This regex is used on web to recognize thread id in the url. When it isn't matched, we navigate to a default thread.

https://linear.app/comm/issue/ENG-9099/opening-a-link-to-a-thick-thread-resets-the-navigation-on-web

Test Plan

Open a web page on a thin thread that isn't the first, refresh the page and check if the same thread is still open.

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Aug 28 2024, 8:20 AM

Herald added a subscriber: ashoat. · View Herald TranscriptAug 28 2024, 8:20 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 28 2024, 8:29 AM

Harbormaster failed remote builds in B31346: Diff 43757!

Harbormaster completed remote builds in B31346: Diff 43757.Aug 28 2024, 8:39 AM

tomek requested review of this revision.Aug 28 2024, 8:39 AM

kamil accepted this revision.Aug 28 2024, 9:34 AM

This revision is now accepted and ready to land.Aug 28 2024, 9:34 AM

tomek added a child revision: D13202: [web] Keep an ID of a thick thread in the URL.Aug 28 2024, 9:57 AM

Closed by commit rCOMM63f1eda390fd: [lib] Update thread and keyserver ID regex (authored by tomek). · Explain WhyAug 28 2024, 10:00 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM63f1eda390fd: [lib] Update thread and keyserver ID regex.

Revision Contents
Changeset List

Path

Size

lib/

utils/

validation-utils.js

4 lines

Diff 43757

lib/utils/validation-utils.js

	// @flow			// @flow

				import type { NotificationsCreationData } from './notif-types.js';
	import type { StoreOperations } from './store-ops-types.js';			import type { StoreOperations } from './store-ops-types.js';

	export type MessageSourceMetadata = {			export type MessageSourceMetadata = {
	+messageID: string,			+messageID: string,
	+senderDeviceID: string,			+senderDeviceID: string,
	};			};

	export type DBOpsEntry =			export type DBOpsEntry =
	\| {			\| {
	+messageSourceMetadata: MessageSourceMetadata,			+messageSourceMetadata: MessageSourceMetadata,
	+ops?: ?StoreOperations,			+ops?: ?StoreOperations,
	}			}
	\| {			\| {
	+ops: StoreOperations,			+ops: StoreOperations,
	+dmOpID?: string,			+dmOpID?: string,
				}
				\| {
				+notificationsCreationData?: NotificationsCreationData,
	};			};

	export type DBOpsStore = {			export type DBOpsStore = {
	+queuedOps: $ReadOnlyArray<DBOpsEntry>,			+queuedOps: $ReadOnlyArray<DBOpsEntry>,
	};			};