[terraform] add PITR to dynamodb tables
ClosedPublic
Actions

Authored by varun on Aug 28 2024, 9:13 AM.

Details

Reviewers

bartek
kamil

Commits

rCOMM30e894ea8f04: [terraform] add PITR to dynamodb tables

Summary

enabled point in time recovery for all tables except identity workflows and nonces. wasn't sure which tables for other services should have this feature so enabled for all of them

Test Plan

confirmed with terraform plan that these changes would enable PITR in production only

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Aug 28 2024, 9:13 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 28 2024, 9:13 AM

Harbormaster completed remote builds in B31354: Diff 43772.Aug 28 2024, 9:30 AM

varun requested review of this revision.Aug 28 2024, 9:30 AM

Generally seems okay to enable it for all these tables

services/terraform/modules/shared/dynamodb.tf
2 ↗	(On Diff #43772)	We have `is_staging = terraform.workspace != "production"`

bartek accepted this revision.Sep 1 2024, 11:34 PM

This revision is now accepted and ready to land.Sep 1 2024, 11:34 PM

varun added inline comments.Sep 2 2024, 6:59 PM

services/terraform/modules/shared/dynamodb.tf
2 ↗	(On Diff #43772)	that local variable is defined in `remote` so it's not available in `modules`

Closed by commit rCOMM30e894ea8f04: [terraform] add PITR to dynamodb tables (authored by varun). · Explain WhySep 2 2024, 6:59 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM30e894ea8f04: [terraform] add PITR to dynamodb tables.

bartek added inline comments.Sep 3 2024, 1:13 AM

services/terraform/modules/shared/dynamodb.tf
2 ↗	(On Diff #43772)	You're right, I missed this. I thought I exposed it somehow to `modules.shared` but it turns out it was `is_dev` which is `false` for both staging and prod

Revision Contents
Changeset List

Path

Size

services/

terraform/

modules/

shared/

dynamodb.tf

52 lines

Diff 43841

View Options

services/terraform/modules/shared/dynamodb.tf

[terraform] add PITR to dynamodb tablesClosedPublicActions