Page MenuHomePhabricator
Differential D13247

[GitHub CI] Clear unused NDKs and iOS simulator to fix Android CI
ClosedPublic
Actions

Authored by ashoat on Sep 5 2024, 9:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 8, 9:27 PM
Unknown Object (File)
Sat, Mar 8, 9:27 PM
Unknown Object (File)
Sat, Mar 8, 9:27 PM
Unknown Object (File)
Sat, Mar 8, 9:27 PM
Unknown Object (File)
Tue, Mar 4, 7:52 PM
Unknown Object (File)
Sun, Mar 2, 6:09 AM
Unknown Object (File)
Jan 17 2025, 1:31 AM
Unknown Object (File)
Jan 17 2025, 1:30 AM
View All 49 Files
Subscribers
tomek

Details

Reviewers
varun
will
Commits
rCOMM3e5b8b08e401: [GitHub CI] Clear unused NDKs and iOS simulator to fix Android CI
Summary

This diff does two things:

  1. Brings back D9464, which was previously removed in D11202
  2. Implements the changes suggested in this GitHub comment to delete iOS simulators and associated caches
Test Plan

I landed the changes to android_ci.yml directly on master and confirmed that the GitHub Actions run succeeded: https://github.com/CommE2E/comm/actions/runs/10722767078/job/29734470192

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/ci
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
.github/
workflows/
15 lines
15 lines

Diff 43897

View Options

.github/workflows/android_ci.yml

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { import {
preparePushNotifs, preparePushNotifs,
type PerUserNotifBuildResult, type PerUserTargetedNotifications,
} from './send-utils.js'; } from './send-utils.js';
import { ENSCacheContext } from '../components/ens-cache-provider.react.js'; import { ENSCacheContext } from '../components/ens-cache-provider.react.js';
import { NeynarClientContext } from '../components/neynar-client-provider.react.js'; import { NeynarClientContext } from '../components/neynar-client-provider.react.js';
import type { MessageData } from '../types/message-types.js'; import type { MessageData } from '../types/message-types.js';
import type {
EncryptedNotifUtilsAPI,
SenderDeviceDescriptor,
} from '../types/notif-types.js';
import { useSelector } from '../utils/redux-utils.js'; import { useSelector } from '../utils/redux-utils.js';
function usePreparePushNotifs(): ( function usePreparePushNotifs(): (
encryptedNotifsUtilsAPI: EncryptedNotifUtilsAPI,
senderDeviceDescriptor: SenderDeviceDescriptor,
messageDatas: $ReadOnlyArray<MessageData>, messageDatas: $ReadOnlyArray<MessageData>,
) => Promise<?PerUserNotifBuildResult> { ) => Promise<?PerUserTargetedNotifications> {
const rawMessageInfos = useSelector(state => state.messageStore.messages); const rawMessageInfos = useSelector(state => state.messageStore.messages);
const rawThreadInfos = useSelector(state => state.threadStore.threadInfos); const rawThreadInfos = useSelector(state => state.threadStore.threadInfos);
const auxUserInfos = useSelector(state => state.auxUserStore.auxUserInfos); const auxUserInfos = useSelector(state => state.auxUserStore.auxUserInfos);
const userInfos = useSelector(state => state.userStore.userInfos); const userInfos = useSelector(state => state.userStore.userInfos);
const { getENSNames } = React.useContext(ENSCacheContext); const { getENSNames } = React.useContext(ENSCacheContext);
const getFCNames = React.useContext(NeynarClientContext)?.getFCNames; const getFCNames = React.useContext(NeynarClientContext)?.getFCNames;
return React.useCallback( return React.useCallback(
(messageDatas: $ReadOnlyArray<MessageData>) => { (
encryptedNotifUtilsAPI: EncryptedNotifUtilsAPI,
senderDeviceDescriptor: SenderDeviceDescriptor,
messageDatas: $ReadOnlyArray<MessageData>,
) => {
return preparePushNotifs({ return preparePushNotifs({
encryptedNotifUtilsAPI,
senderDeviceDescriptor,
messageInfos: rawMessageInfos, messageInfos: rawMessageInfos,
rawThreadInfos, rawThreadInfos,
auxUserInfos, auxUserInfos,
messageDatas, messageDatas,
userInfos, userInfos,
getENSNames, getENSNames,
getFCNames, getFCNames,
}); });
Show All 13 Lines
View Options

.github/workflows/android_release.yml

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { import {
preparePushNotifs, preparePushNotifs,
type PerUserNotifBuildResult, type PerUserTargetedNotifications,
} from './send-utils.js'; } from './send-utils.js';
import { ENSCacheContext } from '../components/ens-cache-provider.react.js'; import { ENSCacheContext } from '../components/ens-cache-provider.react.js';
import { NeynarClientContext } from '../components/neynar-client-provider.react.js'; import { NeynarClientContext } from '../components/neynar-client-provider.react.js';
import type { MessageData } from '../types/message-types.js'; import type { MessageData } from '../types/message-types.js';
import type {
EncryptedNotifUtilsAPI,
SenderDeviceDescriptor,
} from '../types/notif-types.js';
import { useSelector } from '../utils/redux-utils.js'; import { useSelector } from '../utils/redux-utils.js';
function usePreparePushNotifs(): ( function usePreparePushNotifs(): (
encryptedNotifsUtilsAPI: EncryptedNotifUtilsAPI,
senderDeviceDescriptor: SenderDeviceDescriptor,
messageDatas: $ReadOnlyArray<MessageData>, messageDatas: $ReadOnlyArray<MessageData>,
) => Promise<?PerUserNotifBuildResult> { ) => Promise<?PerUserTargetedNotifications> {
const rawMessageInfos = useSelector(state => state.messageStore.messages); const rawMessageInfos = useSelector(state => state.messageStore.messages);
const rawThreadInfos = useSelector(state => state.threadStore.threadInfos); const rawThreadInfos = useSelector(state => state.threadStore.threadInfos);
const auxUserInfos = useSelector(state => state.auxUserStore.auxUserInfos); const auxUserInfos = useSelector(state => state.auxUserStore.auxUserInfos);
const userInfos = useSelector(state => state.userStore.userInfos); const userInfos = useSelector(state => state.userStore.userInfos);
const { getENSNames } = React.useContext(ENSCacheContext); const { getENSNames } = React.useContext(ENSCacheContext);
const getFCNames = React.useContext(NeynarClientContext)?.getFCNames; const getFCNames = React.useContext(NeynarClientContext)?.getFCNames;
return React.useCallback( return React.useCallback(
(messageDatas: $ReadOnlyArray<MessageData>) => { (
encryptedNotifUtilsAPI: EncryptedNotifUtilsAPI,
senderDeviceDescriptor: SenderDeviceDescriptor,
messageDatas: $ReadOnlyArray<MessageData>,
) => {
return preparePushNotifs({ return preparePushNotifs({
encryptedNotifUtilsAPI,
senderDeviceDescriptor,
messageInfos: rawMessageInfos, messageInfos: rawMessageInfos,
rawThreadInfos, rawThreadInfos,
auxUserInfos, auxUserInfos,
messageDatas, messageDatas,
userInfos, userInfos,
getENSNames, getENSNames,
getFCNames, getFCNames,
}); });
Show All 13 Lines