Page MenuHomePhabricator

[GH Actions] Move Android CI workflows to `macOS`
ClosedPublic

Authored by atul on Feb 29 2024, 2:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 14, 11:24 PM
Unknown Object (File)
Thu, Oct 10, 1:10 PM
Unknown Object (File)
Thu, Oct 10, 11:47 AM
Unknown Object (File)
Sep 22 2024, 8:29 PM
Unknown Object (File)
Sep 19 2024, 8:30 PM
Unknown Object (File)
Sep 16 2024, 2:01 PM
Unknown Object (File)
Sep 16 2024, 2:01 PM
Unknown Object (File)
Sep 16 2024, 2:01 PM
Subscribers
None

Details

Summary
Test Plan

Android Build workflow worked on branch:

2647c7.png (1×2 px, 453 KB)

Release should work since that just adds a JS script that's platform agnostic (and I wrote and tested in macOS environment). We should kick off a native release just to give it a shot anyways.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.Feb 29 2024, 2:56 PM
atul added inline comments.
.github/workflows/android_ci.yml
41 ↗(On Diff #37717)

To account for differences between Ubuntu and macOS provided base64.

54 ↗(On Diff #37717)

I previously tried

JAVA_HOME=${JAVA_HOME_11_arm64} ./gradlew bundleRelease

and setting env the same way as ANDROID_SIGNING_PASSWORD, but those workflows failed (very likely for other reasons).

Leaving for now since this worked, but will try moving to match ANDROID_SIGNING_PASSWORD and update if that run works.

60 ↗(On Diff #37717)

~/.gradle already exists on the CI runners so mkdir returns error.

.github/workflows/android_release.yml
28–32 ↗(On Diff #37717)

This also differs from the Android Build workflow.

Wasn't able to test the release workflow on my fork, but did check that mkdir -p works as expected on macOS and there are no differences there.

Thanks for explaining changes inline

.github/workflows/android_ci.yml
60 ↗(On Diff #37717)

Can we make this mkdir -p instead? Better to make it worth for both imo

.github/workflows/android_release.yml
59 ↗(On Diff #37717)

mkdir -p

This revision is now accepted and ready to land.Feb 29 2024, 3:01 PM

bring back mkdir w/ -p flag

setting JAVA_HOME before command worked, using the env approach with ANDROID_SIGNING_PASSWORD didn't.

This revision was landed with ongoing or failed builds.Feb 29 2024, 3:22 PM
This revision was automatically updated to reflect the committed changes.