[native] Bump Android target SDK version to 34
ClosedPublic
Actions

Authored by ashoat on Sep 5 2024, 1:46 PM.

Details

Reviewers

varun
will
marcin

Commits

rCOMM61f2796f6573: [native] Bump Android target SDK version to 34

Summary

This addresses ENG-8812. We need to bump this in order to continue submitting new versions of the Comm Android app to the Play Store.

Depends on D13250

Test Plan

CI and tested running the Android app on simulator. Before releasing this I'll test a release build on a physical Android device and play around with it a bit
cd native && git grep 33 and review all results

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 5 2024, 1:46 PM

Herald added a subscriber: tomek. · View Herald TranscriptSep 5 2024, 1:46 PM

Will make sure this passes CI before landing

varun accepted this revision.Sep 5 2024, 1:47 PM

This revision is now accepted and ready to land.Sep 5 2024, 1:47 PM

Harbormaster completed remote builds in B31442: Diff 43904.Sep 5 2024, 2:03 PM

Closed by commit rCOMM61f2796f6573: [native] Bump Android target SDK version to 34 (authored by ashoat). · Explain WhySep 5 2024, 2:46 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM61f2796f6573: [native] Bump Android target SDK version to 34.

Revision Contents
Changeset List

Path

Size

native/

android/

build.gradle

6 lines

expo-modules/

comm-expo-package/

android/

build.gradle

4 lines

Diff 43906

View Options

native/android/build.gradle