Page MenuHomePhabricator
Differential D13256

Extend pending thread IDs to support thick sidebars
ClosedPublic
Actions

Authored by marcin on Sep 6 2024, 5:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 8 2025, 10:31 PM
Unknown Object (File)
Feb 8 2025, 2:26 AM
Unknown Object (File)
Feb 7 2025, 10:20 PM
Unknown Object (File)
Feb 2 2025, 3:01 PM
Unknown Object (File)
Jan 27 2025, 6:05 AM
Unknown Object (File)
Jan 27 2025, 6:05 AM
Unknown Object (File)
Jan 27 2025, 6:05 AM
Unknown Object (File)
Jan 27 2025, 6:04 AM
View All 43 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMMbbe775f0a586: Extend pending thread IDs to support thick sidebars
Summary

This differential extends pending thread IDs to support thick sidebars.

Test Plan

jest

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-9142
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Sep 6 2024, 5:28 AM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 6 2024, 5:28 AM
Harbormaster completed remote builds in B31454: Diff 43919.Sep 6 2024, 5:55 AM
marcin requested review of this revision.Sep 6 2024, 5:55 AM
inka accepted this revision.Sep 6 2024, 6:07 AM
This revision is now accepted and ready to land.Sep 6 2024, 6:07 AM
Closed by commit rCOMMbbe775f0a586: Extend pending thread IDs to support thick sidebars (authored by marcin). · Explain WhySep 6 2024, 6:11 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMbbe775f0a586: Extend pending thread IDs to support thick sidebars.
tomek added inline comments.Sep 9 2024, 1:09 AM
lib/shared/thread-utils.js
399 ↗(On Diff #43923)

Wondering whether we should expose thick word in the user-facing place, the URL. How about dm_sidebar?

Revision Contents
Changeset List

PathSize
lib/
shared/
32 lines
18 lines
utils/
2 lines

Diff 43919

View Options

lib/shared/thread-utils.js

Show All 26 Linesfunction LinkedDevicesListItem(props: Props): React.Node {
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const colors = useColors(); const colors = useColors();
const { navigate } = useNavigation(); const { navigate } = useNavigation();
const onPress = React.useCallback(() => { const onPress = React.useCallback(() => {
navigate<'LinkedDevicesBottomSheet'>({ navigate<'LinkedDevicesBottomSheet'>({
name: LinkedDevicesBottomSheetRouteName, name: LinkedDevicesBottomSheetRouteName,
params: {
deviceID,
},
}); });
}, [navigate]); }, [deviceID, navigate]);
const deviceType = platformDetails?.deviceType; const deviceType = platformDetails?.deviceType;
const deviceIcon = React.useMemo(() => { const deviceIcon = React.useMemo(() => {
let name; let name;
if ( if (
deviceType === identityDeviceTypes.IOS || deviceType === identityDeviceTypes.IOS ||
deviceType === identityDeviceTypes.ANDROID deviceType === identityDeviceTypes.ANDROID
▲ Show 20 Lines • Show All 69 Lines • Show Last 20 Lines
View Options

lib/shared/thread-utils.test.js

Show All 26 Linesfunction LinkedDevicesListItem(props: Props): React.Node {
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const colors = useColors(); const colors = useColors();
const { navigate } = useNavigation(); const { navigate } = useNavigation();
const onPress = React.useCallback(() => { const onPress = React.useCallback(() => {
navigate<'LinkedDevicesBottomSheet'>({ navigate<'LinkedDevicesBottomSheet'>({
name: LinkedDevicesBottomSheetRouteName, name: LinkedDevicesBottomSheetRouteName,
params: {
deviceID,
},
}); });
}, [navigate]); }, [deviceID, navigate]);
const deviceType = platformDetails?.deviceType; const deviceType = platformDetails?.deviceType;
const deviceIcon = React.useMemo(() => { const deviceIcon = React.useMemo(() => {
let name; let name;
if ( if (
deviceType === identityDeviceTypes.IOS || deviceType === identityDeviceTypes.IOS ||
deviceType === identityDeviceTypes.ANDROID deviceType === identityDeviceTypes.ANDROID
▲ Show 20 Lines • Show All 69 Lines • Show Last 20 Lines
View Options

lib/utils/validation-utils.js

Show All 26 Linesfunction LinkedDevicesListItem(props: Props): React.Node {
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const colors = useColors(); const colors = useColors();
const { navigate } = useNavigation(); const { navigate } = useNavigation();
const onPress = React.useCallback(() => { const onPress = React.useCallback(() => {
navigate<'LinkedDevicesBottomSheet'>({ navigate<'LinkedDevicesBottomSheet'>({
name: LinkedDevicesBottomSheetRouteName, name: LinkedDevicesBottomSheetRouteName,
params: {
deviceID,
},
}); });
}, [navigate]); }, [deviceID, navigate]);
const deviceType = platformDetails?.deviceType; const deviceType = platformDetails?.deviceType;
const deviceIcon = React.useMemo(() => { const deviceIcon = React.useMemo(() => {
let name; let name;
if ( if (
deviceType === identityDeviceTypes.IOS || deviceType === identityDeviceTypes.IOS ||
deviceType === identityDeviceTypes.ANDROID deviceType === identityDeviceTypes.ANDROID
▲ Show 20 Lines • Show All 69 Lines • Show Last 20 Lines