Page MenuHomePhabricator
Differential D13256

Extend pending thread IDs to support thick sidebars
ClosedPublic
Actions

Authored by marcin on Fri, Sep 6, 5:28 AM.
Tags
None
Referenced Files
F2844307: D13256.id43923.diff
Sun, Sep 29, 7:31 PM
F2843589: D13256.diff
Sun, Sep 29, 5:37 PM
Unknown Object (File)
Sat, Sep 28, 12:32 PM
Unknown Object (File)
Sat, Sep 21, 6:34 AM
Unknown Object (File)
Fri, Sep 20, 11:13 PM
Unknown Object (File)
Sun, Sep 15, 12:11 PM
Unknown Object (File)
Fri, Sep 13, 8:43 PM
Unknown Object (File)
Fri, Sep 13, 3:38 PM
View All 17 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMMbbe775f0a586: Extend pending thread IDs to support thick sidebars
Summary

This differential extends pending thread IDs to support thick sidebars.

Test Plan

jest

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-9142
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Fri, Sep 6, 5:28 AM
Herald added a subscriber: ashoat. · View Herald TranscriptFri, Sep 6, 5:28 AM
Harbormaster completed remote builds in B31454: Diff 43919.Fri, Sep 6, 5:55 AM
marcin requested review of this revision.Fri, Sep 6, 5:55 AM
inka accepted this revision.Fri, Sep 6, 6:07 AM
This revision is now accepted and ready to land.Fri, Sep 6, 6:07 AM
Closed by commit rCOMMbbe775f0a586: Extend pending thread IDs to support thick sidebars (authored by marcin). · Explain WhyFri, Sep 6, 6:11 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMbbe775f0a586: Extend pending thread IDs to support thick sidebars.
tomek added inline comments.Mon, Sep 9, 1:09 AM
lib/shared/thread-utils.js
399 ↗(On Diff #43923)

Wondering whether we should expose thick word in the user-facing place, the URL. How about dm_sidebar?

Revision Contents
Changeset List

PathSize
lib/
shared/
32 lines
18 lines
utils/
2 lines

Diff 43919

View Options

lib/shared/thread-utils.js

Loading...
View Options

lib/shared/thread-utils.test.js

Loading...
View Options

lib/utils/validation-utils.js

Loading...