Page MenuHomePhabricator

[lib] Add more keys to redacted values
ClosedPublic

Authored by bartek on Mon, Sep 9, 6:09 AM.
Tags
None
Referenced Files
F2770587: D13270.id43980.diff
Thu, Sep 19, 8:56 PM
Unknown Object (File)
Tue, Sep 17, 12:14 PM
Unknown Object (File)
Tue, Sep 17, 9:45 AM
Unknown Object (File)
Mon, Sep 16, 7:27 PM
Unknown Object (File)
Mon, Sep 16, 8:14 AM
Unknown Object (File)
Mon, Sep 16, 3:12 AM
Unknown Object (File)
Sun, Sep 15, 12:32 PM
Unknown Object (File)
Sun, Sep 15, 11:32 AM
Subscribers

Details

Summary

Address ENG-8717.

  • Added more keys to the redacted lists: CSAT, device lists, encrypted blob data
  • For Blob URIs, created a separate placeholder value
Test Plan

Triggered crash report on my test account. Verified that some Redux values (like commServicesAccessToken) are now redacted.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Mon, Sep 9, 6:40 AM

Thanks for doing this!

This revision is now accepted and ready to land.Mon, Sep 9, 1:40 PM
This revision was automatically updated to reflect the committed changes.