Page MenuHomePhabricator
Differential D13270

[lib] Add more keys to redacted values
ClosedPublic
Actions

Authored by bartek on Sep 9 2024, 6:09 AM.
Tags
None
Referenced Files
F3388018: D13270.id43980.diff
Fri, Nov 29, 12:19 PM
Unknown Object (File)
Tue, Nov 26, 7:00 AM
Unknown Object (File)
Fri, Nov 22, 12:12 PM
Unknown Object (File)
Thu, Nov 14, 1:02 PM
Unknown Object (File)
Thu, Nov 14, 12:59 PM
Unknown Object (File)
Sun, Nov 10, 10:24 PM
Unknown Object (File)
Sun, Nov 10, 6:54 PM
Unknown Object (File)
Sun, Nov 10, 8:01 AM
View All 38 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM5622ed8fcc83: [lib] Add more keys to redacted values
Summary

Address ENG-8717.

  • Added more keys to the redacted lists: CSAT, device lists, encrypted blob data
  • For Blob URIs, created a separate placeholder value
Test Plan

Triggered crash report on my test account. Verified that some Redux values (like commServicesAccessToken) are now redacted.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Sep 9 2024, 6:09 AM
bartek held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptSep 9 2024, 6:09 AM
Harbormaster completed remote builds in B31494: Diff 43980.Sep 9 2024, 6:38 AM
bartek published this revision for review.Sep 9 2024, 6:40 AM
ashoat accepted this revision.Sep 9 2024, 1:40 PM

Thanks for doing this!

This revision is now accepted and ready to land.Sep 9 2024, 1:40 PM
Closed by commit rCOMM5622ed8fcc83: [lib] Add more keys to redacted values (authored by bartek). · Explain WhySep 11 2024, 12:53 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM5622ed8fcc83: [lib] Add more keys to redacted values.

Revision Contents
Changeset List

PathSize
lib/
utils/
17 lines

Diff 43980

View Options

lib/utils/sanitization.js

Loading...