Page MenuHomePhabricator
Differential D13273

[keyserver] convert secondary migration block from do while to regular while loop
ClosedPublic
Actions

Authored by will on Mon, Sep 9, 12:47 PM.
Tags
None
Referenced Files
F2765402: D13273.id44003.diff
Thu, Sep 19, 2:29 PM
F2765241: D13273.id44056.diff
Thu, Sep 19, 2:06 PM
F2753953: D13273.id44056.diff
Wed, Sep 18, 6:32 PM
F2753926: D13273.id.diff
Wed, Sep 18, 6:26 PM
Unknown Object (File)
Tue, Sep 17, 10:07 PM
Unknown Object (File)
Mon, Sep 16, 1:38 PM
Unknown Object (File)
Mon, Sep 16, 12:34 PM
Unknown Object (File)
Mon, Sep 16, 10:44 AM
View All 20 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM7488a4e6fc3a: [keyserver] convert secondary migration block from do while to regular while…
Summary

The do-while ensures an unnecessary 5 second sleep time. Converting this to a while loop ensures this only happens if necessary

Test Plan

flow check

Diff Detail

Repository
rCOMM Comm
Branch
flip_sleep_version_check
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Mon, Sep 9, 12:47 PM
Herald added a subscriber: tomek. · View Herald TranscriptMon, Sep 9, 12:47 PM
will mentioned this in D13213: [keyserver] stall secondary nodes until database version is equal to or greater than latest wrapped in transaction request blocking migration version..Mon, Sep 9, 12:48 PM
Harbormaster completed remote builds in B31506: Diff 44003.Mon, Sep 9, 1:04 PM
will requested review of this revision.Mon, Sep 9, 1:04 PM
ashoat requested changes to this revision.Mon, Sep 9, 1:38 PM

Good point here – can we avoid the sleep unless we need it? I think my feedback here was misguided... we should probably just revert to the version of the code you had before that feedback

This revision now requires changes to proceed.Mon, Sep 9, 1:38 PM
will updated this revision to Diff 44056.Wed, Sep 11, 12:47 PM

review feedback

will retitled this revision from [keyserver] flip sleep and db version check to [keyserver] convert secondary migration block from do while to regular while loop.Wed, Sep 11, 12:48 PM
will edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B31547: Diff 44056.Wed, Sep 11, 1:04 PM
ashoat accepted this revision.Wed, Sep 11, 1:07 PM

Thanks, and sorry for my confusion!

This revision is now accepted and ready to land.Wed, Sep 11, 1:07 PM
Closed by commit rCOMM7488a4e6fc3a: [keyserver] convert secondary migration block from do while to regular while… (authored by will). · Explain WhyWed, Sep 11, 1:56 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM7488a4e6fc3a: [keyserver] convert secondary migration block from do while to regular while….

Revision Contents
Changeset List

PathSize
keyserver/
src/
4 lines

Diff 44003

View Options

keyserver/src/keyserver.js

Loading...