Page MenuHomePhabricator

Update threadIsPendingSidebar to handle thick sidebars
ClosedPublic

Authored by marcin on Sep 10 2024, 7:07 AM.
Tags
None
Referenced Files
F3299523: D13274.id44009.diff
Sun, Nov 17, 12:59 PM
F3299521: D13274.id44041.diff
Sun, Nov 17, 12:57 PM
F3293482: D13274.diff
Sat, Nov 16, 5:15 PM
Unknown Object (File)
Thu, Nov 14, 1:02 PM
Unknown Object (File)
Thu, Nov 14, 12:59 PM
Unknown Object (File)
Fri, Nov 1, 6:19 AM
Unknown Object (File)
Fri, Nov 1, 6:17 AM
Unknown Object (File)
Fri, Nov 1, 6:17 AM
Subscribers

Details

Summary

This differential updates threadIsPendingSidebar to handle thick sidebars as well

Test Plan

Test was added to thread-utils.test.js

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-9174
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

This revision is now accepted and ready to land.Sep 11 2024, 2:07 AM
tomek added inline comments.
lib/shared/thread-utils.js
377–378

Can we extract sidebar and dm_sidebar somewhere as constants?

Extract sidebar and dm_sidebar to constants

This revision was landed with ongoing or failed builds.Sep 11 2024, 7:04 AM
This revision was automatically updated to reflect the committed changes.