Page MenuHomePhabricator

[identity] don't check reserved_usernames.json when registering existing users from keyserver
ClosedPublic

Authored by varun on Tue, Sep 10, 12:55 PM.
Tags
None
Referenced Files
F2771527: D13276.diff
Thu, Sep 19, 11:35 PM
Unknown Object (File)
Wed, Sep 18, 8:39 PM
Unknown Object (File)
Wed, Sep 18, 6:08 AM
Unknown Object (File)
Wed, Sep 18, 5:15 AM
Unknown Object (File)
Mon, Sep 16, 5:23 PM
Unknown Object (File)
Sun, Sep 15, 8:37 PM
Unknown Object (File)
Sun, Sep 15, 6:55 AM
Unknown Object (File)
Sun, Sep 15, 5:13 AM
Subscribers

Details

Summary

https://linear.app/comm/issue/ENG-9247/register-reserved-password-user-start-rejects-already-registered

If a username is already registered with ashoat's keyserver, there's no need to check if it's in reserved_usernames.json. We should just allow the username to be registered on the identity service via the reserved registration workflow.

Test Plan
  • Registered username book with my keyserver by setting usingCSAT to false and modifying the reserved usernames js file. Keyserver added username to reserved usernames table on staging identity.
  • Flipped usingCSAT to true, was registered with staging identity

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable