Page MenuHomePhabricator
Differential D13274

Update threadIsPendingSidebar to handle thick sidebars
ClosedPublic
Actions

Authored by marcin on Sep 10 2024, 7:07 AM.
Tags
None
Referenced Files
F3299523: D13274.id44009.diff
Sun, Nov 17, 12:59 PM
F3299521: D13274.id44041.diff
Sun, Nov 17, 12:57 PM
F3293482: D13274.diff
Sat, Nov 16, 5:15 PM
Unknown Object (File)
Thu, Nov 14, 1:02 PM
Unknown Object (File)
Thu, Nov 14, 12:59 PM
Unknown Object (File)
Fri, Nov 1, 6:19 AM
Unknown Object (File)
Fri, Nov 1, 6:17 AM
Unknown Object (File)
Fri, Nov 1, 6:17 AM
View All 58 Files
Subscribers
ashoat

Details

Reviewers
inka
tomek
Commits
rCOMM085726ba64cd: Update threadIsPendingSidebar to handle thick sidebars
Summary

This differential updates threadIsPendingSidebar to handle thick sidebars as well

Test Plan

Test was added to thread-utils.test.js

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-9174
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Sep 10 2024, 7:07 AM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 10 2024, 7:07 AM
Harbormaster completed remote builds in B31508: Diff 44009.Sep 10 2024, 7:28 AM
marcin requested review of this revision.Sep 10 2024, 7:28 AM
inka accepted this revision.Sep 11 2024, 2:07 AM

Thank you!

This revision is now accepted and ready to land.Sep 11 2024, 2:07 AM
tomek accepted this revision.Sep 11 2024, 2:08 AM
tomek added inline comments.
lib/shared/thread-utils.js
377–378 ↗(On Diff #44009)

Can we extract sidebar and dm_sidebar somewhere as constants?

marcin updated this revision to Diff 44036.Sep 11 2024, 4:42 AM

Extract sidebar and dm_sidebar to constants

Harbormaster completed remote builds in B31530: Diff 44036.Sep 11 2024, 4:59 AM
marcin updated this revision to Diff 44040.Sep 11 2024, 7:02 AM

rebase before landing

This revision was landed with ongoing or failed builds.Sep 11 2024, 7:04 AM
Closed by commit rCOMM085726ba64cd: Update threadIsPendingSidebar to handle thick sidebars (authored by marcin). · Explain Why
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM085726ba64cd: Update threadIsPendingSidebar to handle thick sidebars.
Harbormaster completed remote builds in B31533: Diff 44040.Sep 11 2024, 7:30 AM

Revision Contents
Changeset List

PathSize
lib/
shared/
22 lines
26 lines
utils/
6 lines

Diff 44036

View Options

lib/shared/thread-utils.js

Loading...
View Options

lib/shared/thread-utils.test.js

Loading...
View Options

lib/utils/validation-utils.js

Loading...