Page MenuHomePhabricator
Differential D13273

[keyserver] convert secondary migration block from do while to regular while loop
ClosedPublic
Actions

Authored by will on Sep 9 2024, 12:47 PM.
Tags
None
Referenced Files
F3570463: D13273.id44056.diff
Sat, Dec 28, 5:28 AM
F3570458: D13273.id44060.diff
Sat, Dec 28, 5:28 AM
Unknown Object (File)
Wed, Dec 18, 7:15 AM
Unknown Object (File)
Wed, Dec 18, 7:15 AM
Unknown Object (File)
Wed, Dec 18, 7:14 AM
Unknown Object (File)
Nov 25 2024, 7:25 PM
Unknown Object (File)
Nov 25 2024, 7:07 PM
Unknown Object (File)
Nov 25 2024, 6:56 PM
View All 61 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM7488a4e6fc3a: [keyserver] convert secondary migration block from do while to regular while…
Summary

The do-while ensures an unnecessary 5 second sleep time. Converting this to a while loop ensures this only happens if necessary

Test Plan

flow check

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Sep 9 2024, 12:47 PM
Herald added a subscriber: tomek. · View Herald TranscriptSep 9 2024, 12:47 PM
will mentioned this in D13213: [keyserver] stall secondary nodes until database version is equal to or greater than latest wrapped in transaction request blocking migration version..Sep 9 2024, 12:48 PM
Harbormaster completed remote builds in B31506: Diff 44003.Sep 9 2024, 1:04 PM
will requested review of this revision.Sep 9 2024, 1:04 PM
ashoat requested changes to this revision.Sep 9 2024, 1:38 PM

Good point here – can we avoid the sleep unless we need it? I think my feedback here was misguided... we should probably just revert to the version of the code you had before that feedback

This revision now requires changes to proceed.Sep 9 2024, 1:38 PM
will updated this revision to Diff 44056.Sep 11 2024, 12:47 PM

review feedback

will retitled this revision from [keyserver] flip sleep and db version check to [keyserver] convert secondary migration block from do while to regular while loop.Sep 11 2024, 12:48 PM
will edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B31547: Diff 44056.Sep 11 2024, 1:04 PM
ashoat accepted this revision.Sep 11 2024, 1:07 PM

Thanks, and sorry for my confusion!

This revision is now accepted and ready to land.Sep 11 2024, 1:07 PM
Closed by commit rCOMM7488a4e6fc3a: [keyserver] convert secondary migration block from do while to regular while… (authored by will). · Explain WhySep 11 2024, 1:56 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM7488a4e6fc3a: [keyserver] convert secondary migration block from do while to regular while….

Revision Contents
Changeset List

PathSize
keyserver/
src/
6 lines

Diff 44060

View Options

keyserver/src/keyserver.js

Loading...