[lib] Avoid useless updateRelationships call when logged out in handleFarcasterMutuals
ClosedPublic
Actions

Authored by ashoat on Sep 11 2024, 2:43 PM.

Details

Reviewers

will
varun

Commits

rCOMMa7e8494f10f0: [lib] Avoid useless updateRelationships call when logged out in…

Summary

This addresses ENG-9229.

Test Plan

We use a similar strategy here, which has been tested. This change is safe because it's simple and is using an approach I've tested before

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/farcasterdatahandler

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Sep 11 2024, 2:43 PM

Herald added a subscriber: tomek. · View Herald TranscriptSep 11 2024, 2:43 PM

Harbormaster completed remote builds in B31549: Diff 44061.Sep 11 2024, 3:01 PM

ashoat requested review of this revision.Sep 11 2024, 3:01 PM

This change is safe because it's safe and is using an approach I've tested before

Code makes sense but I wonder if you meant to say something else here

This revision is now accepted and ready to land.Sep 12 2024, 3:05 AM

Thanks, fixed

Closed by commit rCOMMa7e8494f10f0: [lib] Avoid useless updateRelationships call when logged out in… (authored by ashoat). · Explain WhySep 12 2024, 3:08 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMa7e8494f10f0: [lib] Avoid useless updateRelationships call when logged out in….

Revision Contents
Changeset List

Path

Size

lib/

components/

farcaster-data-handler.react.js

13 lines

Diff 44061

View Options

lib/components/farcaster-data-handler.react.js

[lib] Avoid useless updateRelationships call when logged out in handleFarcasterMutualsClosedPublicActions